Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error
On Fri, Apr 1, 2011 at 7:46 PM, Blue Swirl blauwir...@gmail.com wrote: I think the only reasonable use for C99 comments is //#define DEBUG_xyz for quickly enabling debugging printfs. But even this pattern should be replaced by tracepoints, since they are much better. So I'd prefer to keep the ERROR. Please update CODING_STYLE. Stefan
[Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error
C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/checkpatch.pl |2 +- test.c|5 + 2 files changed, 6 insertions(+), 1 deletions(-) create mode 100644 test.c diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 770d534..2aab4e9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1799,7 +1799,7 @@ sub process { # no C99 // comments if ($line =~ m{//}) { - ERROR(do not use C99 // comments\n . $herecurr); + WARN(do not use C99 // comments\n . $herecurr); } # Remove C99 comments. $line =~ s@//.*@@; diff --git a/test.c b/test.c new file mode 100644 index 000..fe3b163 --- /dev/null +++ b/test.c @@ -0,0 +1,5 @@ +//stuff +static int blah(void) +{ +return 1; +} -- 1.7.0.4
Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error
On Fri, Apr 1, 2011 at 4:20 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/checkpatch.pl | 2 +- test.c | 5 + 2 files changed, 6 insertions(+), 1 deletions(-) create mode 100644 test.c Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error
On Fri, Apr 1, 2011 at 6:20 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/checkpatch.pl | 2 +- test.c | 5 + 2 files changed, 6 insertions(+), 1 deletions(-) create mode 100644 test.c diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 770d534..2aab4e9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1799,7 +1799,7 @@ sub process { # no C99 // comments if ($line =~ m{//}) { - ERROR(do not use C99 // comments\n . $herecurr); + WARN(do not use C99 // comments\n . $herecurr); I think the only reasonable use for C99 comments is //#define DEBUG_xyz for quickly enabling debugging printfs. But even this pattern should be replaced by tracepoints, since they are much better. So I'd prefer to keep the ERROR.