[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
Fix in 2.7.0 release thanks to commit bce6261eb2d879625126485d4ddd28cacb93152e Author: Daniel P. Berrange Date: Wed Aug 3 17:22:36 2016 +0100 virtio-console: set frontend open permanently for console devs The virtio-console.c file handles both serial consoles and interactive consoles, since they're backed by the same device model. Since serial devices are expected to be reliable and need to notify the guest when the backend is opened or closed, the virtio-console.c file wires up support for chardev events. This affects both serial consoles and interactive consoles, using a network connection based chardev backend such as 'socket', but not when using a PTY based backend or plain 'file' backends. When the host side is not connected the handle_output() method in virtio-serial-bus.c will drop any data sent by the guest, before it even reaches the virtio-console.c code. This means that if the chardev has a logfile configured, the data will never get logged. Consider for example, configuring a x86_64 guest with a plain UART serial port -chardev socket,id=charserial1,host=127.0.0.1,port=9001,server,nowait,logfile=console1.log,logappend=on -device isa-serial,chardev=charserial1,id=serial1 vs a s390 guest which has to use the virtio-console port -chardev socket,id=charconsole1,host=127.0.0.1,port=9000,server,nowait,logfile=console2.log,logappend=on -device virtconsole,chardev=charconsole1,id=console1 The isa-serial one gets data written to the log regardless of whether a client is connected, while the virtioconsole one only gets data written to the log when a client is connected. There is no need for virtio-serial-bus.c to aggressively drop the data for console devices, as the chardev code is prefectly capable of discarding the data itself. So this patch changes virtconsole devices so that they are always marked as having the host side open. This ensures that the guest OS will always send any data it has (Linux virtio-console hvc driver actually ignores the host open state and sends data regardless, but we should not rely on that), and also prevents the virtio-serial-bus code prematurely discarding data. The behaviour of virtserialport devices is *not* changed, only virtconsole, because for the former, it is important that the guest OSknow exactly when the host side is opened / closed so it can do any protocol re-negotiation that may be required. Fixes bug: https://bugs.launchpad.net/qemu/+bug/1599214 Acked-by: Cornelia Huck Signed-off-by: Daniel P. Berrange Message-Id: <1470241360-3574-2-git-send-email-berra...@redhat.com> Signed-off-by: Amit Shah ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: Fix Released Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
Can you provide the full QEMU command line arguments you're using to reproduce this problem. I tested a guest with the following console config: and confirmed that the log file gets written, even when no client is connected to the UNIX domain socket. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: Incomplete Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
qemu log: http://paste.openstack.org/show/542559/ ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
Ok, relevant part of command line is -add-fd set=2,fd=33 -chardev socket,id=charconsole0,host=9.152.151.129,port=1,server,nowait,logfile=/dev/fdset/2,logappend=on -device virtconsole,chardev=charconsole0,id=console0 -chardev pty,id=charconsole1 -device sclpconsole,chardev=charconsole1,id=console1 Which shows a TCP based serial console with log file -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
> Which shows a TCP based serial console with log file Yes, that's true. It's also on the s390x architecture. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
The char device in the libvirt domain XML is this: Full domain XML: http://paste.openstack.org/show/542597/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
Ok, so the problem is a difference in behaviour for virtio-console vs serial ports. For plain x86 serial ports, if there's no client connected to the backend, any data is just discarded. For virtio-console, if there's no client connected to the backend, it'll refuse to send data, hence we never get to log it either. What i'm not sure on is whether this is supposed to work this way. The virtio-console device actually provides two separate services - a paravirt serial port and a paravirt interactive console. The paravirt serial port mode, certainly requires this behaviour, but I'm not convinced the console mode should do this. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
Patch at https://lists.gnu.org/archive/html/qemu- devel/2016-07/msg06708.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
** Changed in: qemu Assignee: (unassigned) => Daniel Berrange (berrange) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
[Qemu-devel] [Bug 1599214] Re: virtlogd: qemu 2.6.0 doesn't log boot message
** Description changed: This report is related to the OpenStack Nova bug [1]. - OpenStack tries to utilize the "virtlogd" feature of qemu [2]. + OpenStack tries to utilize the "virtlogd" feature of libvirt which gets + provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599214 Title: virtlogd: qemu 2.6.0 doesn't log boot message Status in QEMU: New Bug description: This report is related to the OpenStack Nova bug [1]. OpenStack tries to utilize the "virtlogd" feature of libvirt which gets provided by qemu with [2]. steps to reproduce: 1) launch a quest with qemu 2.6.0 which uses virtlogd for the stdout/stderr of its char device 2) check the contents of the backing file of that char device expected result: The boot messages of the guest are logged in this file actual result: The file is empty notes: When I'm connected to that char device and reboot the guest, I see the boot messages in the terminal and also in the backing log file. References: [1] https://bugs.launchpad.net/nova/+bug/1597789 [2] http://git.qemu.org/?p=qemu.git;a=blobdiff;f=qemu-char.c;h=11caa5648de99c9e0ee158f280fbc02ab05915d3;hp=d7be1851e5e9d268aa924a05958da292b048839c;hb=d0d7708ba29cbcc343364a46bff981e0ff88366f;hpb=f1c17521e79df863a5771d96974fab0d07f02be0 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1599214/+subscriptions
