[Qemu-devel] [Bug 1715007] Re: hw/block/onenand.c:520: dead code ?

2017-12-15 Thread Thomas Huth 
** Changed in: qemu
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1715007

Title:
  hw/block/onenand.c:520: dead code ?

Status in QEMU:
  Fix Released

Bug description:
  qemu/hw/block/onenand.c:520] -> [qemu/hw/block/onenand.c:521]:
  (warning) Opposite inner 'if' condition leads to a dead code block.

  Source code is

  for (b = 0; b < s->blocks; b ++) {
  if (b >= s->blocks) {
  s->status |= ONEN_ERR_CMD;
  break;
  }

  I am not sure if the if condition can be merely deleted, or something more
  complex needs to be implemented.

  Recent qemu trunk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1715007/+subscriptions

[Qemu-devel] [Bug 1715007] Re: hw/block/onenand.c:520: dead code ?

2017-10-11 Thread Thomas Huth 
Fix has now been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=dbfa934106d22402d

** Changed in: qemu
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1715007

Title:
  hw/block/onenand.c:520: dead code ?

Status in QEMU:
  Fix Committed

Bug description:
  qemu/hw/block/onenand.c:520] -> [qemu/hw/block/onenand.c:521]:
  (warning) Opposite inner 'if' condition leads to a dead code block.

  Source code is

  for (b = 0; b < s->blocks; b ++) {
  if (b >= s->blocks) {
  s->status |= ONEN_ERR_CMD;
  break;
  }

  I am not sure if the if condition can be merely deleted, or something more
  complex needs to be implemented.

  Recent qemu trunk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1715007/+subscriptions