Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
On 28.07.2014, at 15:43, Alexander Graf wrote: > > On 10.07.14 15:27, David Hildenbrand wrote: This is the qemu part of kernel series "Let user space control the cpu states" Christian Borntraeger (1): update linux headers with with cpustate changes David Hildenbrand (4): s390x/kvm: introduce proper states for s390 cpus s390x/kvm: proper use of the cpu states OPERATING and STOPPED s390x/kvm: test whether a cpu is STOPPED when checking "has_work" s390x/kvm: propagate s390 cpu state to kvm hw/s390x/ipl.c| 2 +- hw/s390x/s390-virtio.c| 32 -- linux-headers/linux/kvm.h | 7 ++- target-s390x/cpu.c| 106 +++--- target-s390x/cpu.h| 33 +-- target-s390x/helper.c | 11 ++--- target-s390x/kvm.c| 49 ++--- trace-events | 6 +++ 8 files changed, 179 insertions(+), 67 deletions(-) >>> Looks good to me >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe kvm" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> @all thought it was the final internal review :) > > It's a perfectly good thing to say "looks good to me" in public too. The only > major difference is that usually you would say "reviewed-by" ;). Meh - only realized after I sent this that all those patches are From: you. Then of course it's not useful ;) Alex
Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
On 10.07.14 15:27, David Hildenbrand wrote: This is the qemu part of kernel series "Let user space control the cpu states" Christian Borntraeger (1): update linux headers with with cpustate changes David Hildenbrand (4): s390x/kvm: introduce proper states for s390 cpus s390x/kvm: proper use of the cpu states OPERATING and STOPPED s390x/kvm: test whether a cpu is STOPPED when checking "has_work" s390x/kvm: propagate s390 cpu state to kvm hw/s390x/ipl.c| 2 +- hw/s390x/s390-virtio.c| 32 -- linux-headers/linux/kvm.h | 7 ++- target-s390x/cpu.c| 106 +++--- target-s390x/cpu.h| 33 +-- target-s390x/helper.c | 11 ++--- target-s390x/kvm.c| 49 ++--- trace-events | 6 +++ 8 files changed, 179 insertions(+), 67 deletions(-) Looks good to me -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html @all thought it was the final internal review :) It's a perfectly good thing to say "looks good to me" in public too. The only major difference is that usually you would say "reviewed-by" ;). Alex
[Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
This is the qemu part of kernel series "Let user space control the cpu states" Christian Borntraeger (1): update linux headers with with cpustate changes David Hildenbrand (4): s390x/kvm: introduce proper states for s390 cpus s390x/kvm: proper use of the cpu states OPERATING and STOPPED s390x/kvm: test whether a cpu is STOPPED when checking "has_work" s390x/kvm: propagate s390 cpu state to kvm hw/s390x/ipl.c| 2 +- hw/s390x/s390-virtio.c| 32 -- linux-headers/linux/kvm.h | 7 ++- target-s390x/cpu.c| 106 +++--- target-s390x/cpu.h| 33 +-- target-s390x/helper.c | 11 ++--- target-s390x/kvm.c| 49 ++--- trace-events | 6 +++ 8 files changed, 179 insertions(+), 67 deletions(-) -- 1.8.4.2
Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
> > This is the qemu part of kernel series "Let user space control the > > cpu states" > > > > Christian Borntraeger (1): > > update linux headers with with cpustate changes > > > > David Hildenbrand (4): > > s390x/kvm: introduce proper states for s390 cpus > > s390x/kvm: proper use of the cpu states OPERATING and STOPPED > > s390x/kvm: test whether a cpu is STOPPED when checking "has_work" > > s390x/kvm: propagate s390 cpu state to kvm > > > > hw/s390x/ipl.c| 2 +- > > hw/s390x/s390-virtio.c| 32 -- > > linux-headers/linux/kvm.h | 7 ++- > > target-s390x/cpu.c| 106 > > +++--- > > target-s390x/cpu.h| 33 +-- > > target-s390x/helper.c | 11 ++--- > > target-s390x/kvm.c| 49 ++--- > > trace-events | 6 +++ > > 8 files changed, 179 insertions(+), 67 deletions(-) > > > > Looks good to me > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > @all thought it was the final internal review :)
Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
> This is the qemu part of kernel series "Let user space control the > cpu states" > > Christian Borntraeger (1): > update linux headers with with cpustate changes > > David Hildenbrand (4): > s390x/kvm: introduce proper states for s390 cpus > s390x/kvm: proper use of the cpu states OPERATING and STOPPED > s390x/kvm: test whether a cpu is STOPPED when checking "has_work" > s390x/kvm: propagate s390 cpu state to kvm > > hw/s390x/ipl.c| 2 +- > hw/s390x/s390-virtio.c| 32 -- > linux-headers/linux/kvm.h | 7 ++- > target-s390x/cpu.c| 106 > +++--- > target-s390x/cpu.h| 33 +-- > target-s390x/helper.c | 11 ++--- > target-s390x/kvm.c| 49 ++--- > trace-events | 6 +++ > 8 files changed, 179 insertions(+), 67 deletions(-) > Looks good to me
Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm
> This is the qemu part of kernel series "Let user space control the > cpu states" > > Christian Borntraeger (1): > update linux headers with with cpustate changes > > David Hildenbrand (4): > s390x/kvm: introduce proper states for s390 cpus > s390x/kvm: proper use of the cpu states OPERATING and STOPPED > s390x/kvm: test whether a cpu is STOPPED when checking "has_work" > s390x/kvm: propagate s390 cpu state to kvm > > hw/s390x/ipl.c| 2 +- > hw/s390x/s390-virtio.c| 32 -- > linux-headers/linux/kvm.h | 7 ++- > target-s390x/cpu.c| 106 > +++--- > target-s390x/cpu.h| 33 +-- > target-s390x/helper.c | 11 ++--- > target-s390x/kvm.c| 49 ++--- > trace-events | 6 +++ > 8 files changed, 179 insertions(+), 67 deletions(-) > Looks good to me.