subject:"\[Qemu\-devel\] \[PATCH\] Haiku\: Platform build fixes"

[Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Alexander von Gluck IV

* skip syscall.h on Haiku
* skip signal.h on Haiku
* no daemon function
* only attach SIGIO when it exists
* use termios.h on Haiku
---
 main-loop.c |2 +
 os-posix.c  |4 ++
 target-xtensa/xtensa-semi.c |   84 ---
 tests/Makefile  |2 +-
 util/compatfd.c |2 +
 util/oslib-posix.c  |7 
 util/qemu-openpty.c |4 ++-
 7 files changed, 58 insertions(+), 47 deletions(-)

diff --git a/main-loop.c b/main-loop.c
index 981bcb5..947d7cd 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -81,7 +81,9 @@ static int qemu_signal_init(void)
  */
 sigemptyset(set);
 sigaddset(set, SIG_IPI);
+#ifdef SIGIO
 sigaddset(set, SIGIO);
+#endif
 sigaddset(set, SIGALRM);
 sigaddset(set, SIGBUS);
 /* SIGINT cannot be handled via signalfd, so that ^C can be used
diff --git a/os-posix.c b/os-posix.c
index ba091f1..43f7fec 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -323,6 +323,9 @@ bool is_daemonized(void)
 
 int os_mlock(void)
 {
+#if defined(CONFIG_HAIKU)
+return ENOSYS;
+#else
 int ret = 0;
 
 ret = mlockall(MCL_CURRENT | MCL_FUTURE);
@@ -331,4 +334,5 @@ int os_mlock(void)
 }
 
 return ret;
+#endif
 }
diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c
index 16e9d8c..d0ea12a 100644
--- a/target-xtensa/xtensa-semi.c
+++ b/target-xtensa/xtensa-semi.c
@@ -95,59 +95,53 @@ enum {
 
 static uint32_t errno_h2g(int host_errno)
 {
-static const uint32_t guest_errno[] = {
-[EPERM] = TARGET_EPERM,
-[ENOENT]= TARGET_ENOENT,
-[ESRCH] = TARGET_ESRCH,
-[EINTR] = TARGET_EINTR,
-[EIO]   = TARGET_EIO,
-[ENXIO] = TARGET_ENXIO,
-[E2BIG] = TARGET_E2BIG,
-[ENOEXEC]   = TARGET_ENOEXEC,
-[EBADF] = TARGET_EBADF,
-[ECHILD]= TARGET_ECHILD,
-[EAGAIN]= TARGET_EAGAIN,
-[ENOMEM]= TARGET_ENOMEM,
-[EACCES]= TARGET_EACCES,
-[EFAULT]= TARGET_EFAULT,
+switch (host_errno) {
+case 0: return 0;
+case EPERM: return TARGET_EPERM;
+case ENOENT: return TARGET_ENOENT;
+case ESRCH: return TARGET_ESRCH;
+case EINTR: return TARGET_EINTR;
+case EIO: return TARGET_EIO;
+case ENXIO: return TARGET_ENXIO;
+case E2BIG: return TARGET_E2BIG;
+case ENOEXEC: return TARGET_ENOEXEC;
+case EBADF: return TARGET_EBADF;
+case ECHILD: return TARGET_ECHILD;
+case EAGAIN: return TARGET_EAGAIN;
+case ENOMEM: return TARGET_ENOMEM;
+case EACCES: return TARGET_EACCES;
+case EFAULT: return TARGET_EFAULT;
 #ifdef ENOTBLK
-[ENOTBLK]   = TARGET_ENOTBLK,
+case ENOTBLK: return TARGET_ENOTBLK;
 #endif
-[EBUSY] = TARGET_EBUSY,
-[EEXIST]= TARGET_EEXIST,
-[EXDEV] = TARGET_EXDEV,
-[ENODEV]= TARGET_ENODEV,
-[ENOTDIR]   = TARGET_ENOTDIR,
-[EISDIR]= TARGET_EISDIR,
-[EINVAL]= TARGET_EINVAL,
-[ENFILE]= TARGET_ENFILE,
-[EMFILE]= TARGET_EMFILE,
-[ENOTTY]= TARGET_ENOTTY,
+case EBUSY: return TARGET_EBUSY;
+case EEXIST: return TARGET_EEXIST;
+case EXDEV: return TARGET_EXDEV;
+case ENODEV: return TARGET_ENODEV;
+case ENOTDIR: return TARGET_ENOTDIR;
+case EISDIR: return TARGET_EISDIR;
+case EINVAL: return TARGET_EINVAL;
+case ENFILE: return TARGET_ENFILE;
+case EMFILE: return TARGET_EMFILE;
+case ENOTTY: return TARGET_ENOTTY;
 #ifdef ETXTBSY
-[ETXTBSY]   = TARGET_ETXTBSY,
+case ETXTBSY: return TARGET_ETXTBSY;
 #endif
-[EFBIG] = TARGET_EFBIG,
-[ENOSPC]= TARGET_ENOSPC,
-[ESPIPE]= TARGET_ESPIPE,
-[EROFS] = TARGET_EROFS,
-[EMLINK]= TARGET_EMLINK,
-[EPIPE] = TARGET_EPIPE,
-[EDOM]  = TARGET_EDOM,
-[ERANGE]= TARGET_ERANGE,
-[ENOSYS]= TARGET_ENOSYS,
+case EFBIG: return TARGET_EFBIG;
+case ENOSPC: return TARGET_ENOSPC;
+case ESPIPE: return TARGET_ESPIPE;
+case EROFS: return TARGET_EROFS;
+case EMLINK: return TARGET_EMLINK;
+case EPIPE: return TARGET_EPIPE;
+case EDOM: return TARGET_EDOM;
+case ERANGE: return TARGET_ERANGE;
+case ENOSYS: return TARGET_ENOSYS;
 #ifdef ELOOP
-[ELOOP] = TARGET_ELOOP,
+case ELOOP: return TARGET_ELOOP;
 #endif
 };
 
-if (host_errno == 0) {
-return 0;
-} else if (host_errno  0  host_errno  ARRAY_SIZE(guest_errno) 
-guest_errno[host_errno]) {
-return guest_errno[host_errno];
-} else {
-return TARGET_EINVAL;

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread François Revol

On 24/03/2015 23:56, Max Filippov wrote:
 On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber afaer...@suse.de wrote:
 Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:


 Why convert from array to switch statement? It looks like a very
 invasive change for no obvious reason.
 
 I'd be interested to know the reason too, but I'm OK with either way.

Maybe because negative array indices are usually a bad idea in C?
Are the host errno codes used there actually?

François.

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Andreas Färber

Am 25.03.2015 um 00:11 schrieb Max Filippov:
 On Wed, Mar 25, 2015 at 2:03 AM, François Revol re...@free.fr wrote:
 On 24/03/2015 23:56, Max Filippov wrote:
 On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber afaer...@suse.de wrote:
 Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:


 Why convert from array to switch statement? It looks like a very
 invasive change for no obvious reason.

 I'd be interested to know the reason too, but I'm OK with either way.

 Maybe because negative array indices are usually a bad idea in C?
 
 Sounds like a good reason (:

True, but assumes that error codes are indeed negative.

AFAIU linking with -lposix_error_helper or so (- configure/Makefile*)
may be an alternative, keeping errors POSIX-compliant in our code. I
don't recall the implementation details though...

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread François Revol

On 25/03/2015 00:40, Andreas Färber wrote:
 Am 25.03.2015 um 00:11 schrieb Max Filippov:
 On Wed, Mar 25, 2015 at 2:03 AM, François Revol re...@free.fr wrote:
 On 24/03/2015 23:56, Max Filippov wrote:
 On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber afaer...@suse.de wrote:
 Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:


 Why convert from array to switch statement? It looks like a very
 invasive change for no obvious reason.

 I'd be interested to know the reason too, but I'm OK with either way.

 Maybe because negative array indices are usually a bad idea in C?

 Sounds like a good reason (:
 
 True, but assumes that error codes are indeed negative.
 
 AFAIU linking with -lposix_error_helper or so (- configure/Makefile*)
 may be an alternative, keeping errors POSIX-compliant in our code. I
 don't recall the implementation details though...

Indeed, although it doesn't solve everything (some things like nginx
want to use deprecated things like sys_errlist[] (although they dropped
this) or assume the codes are all  some very low positive value), and I
suspect it could have strange side effects on code used as a library by
other things.

As for myself, I consider POSIX to be boggus (they even changed their
mind in some places) and error prone on this (I've ported enough foreign
code to assert this) :p

François.

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Max Filippov

On Wed, Mar 25, 2015 at 2:03 AM, François Revol re...@free.fr wrote:
 On 24/03/2015 23:56, Max Filippov wrote:
 On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber afaer...@suse.de wrote:
 Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:


 Why convert from array to switch statement? It looks like a very
 invasive change for no obvious reason.

 I'd be interested to know the reason too, but I'm OK with either way.

 Maybe because negative array indices are usually a bad idea in C?

Sounds like a good reason (:

 Are the host errno codes used there actually?

Yes.

-- 
Thanks.
-- Max

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Andreas Färber

Hi Alexander,

Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:
 * skip syscall.h on Haiku
 * skip signal.h on Haiku
 * no daemon function
 * only attach SIGIO when it exists
 * use termios.h on Haiku

We cannot accept patches without Signed-off-by, indicating that this
code is either from you or someone who has signed it off before you
according to the DCO.

That is, if you took this patch from HaikuPorts, you'll need to track
down who wrote which parts of this and get them to sign off before
resubmitting here. Michael Lotz never responded after posting the
previous big patch.

 ---
  main-loop.c |2 +
  os-posix.c  |4 ++
  target-xtensa/xtensa-semi.c |   84 
 ---
  tests/Makefile  |2 +-
  util/compatfd.c |2 +
  util/oslib-posix.c  |7 
  util/qemu-openpty.c |4 ++-
  7 files changed, 58 insertions(+), 47 deletions(-)

Can you split this up into a series of smaller patches? That'll make it
easier to start applying fixes.

You also forgot to CC the Xtensa maintainer whose code you are touching.

 
 diff --git a/main-loop.c b/main-loop.c
 index 981bcb5..947d7cd 100644
 --- a/main-loop.c
 +++ b/main-loop.c
 @@ -81,7 +81,9 @@ static int qemu_signal_init(void)
   */
  sigemptyset(set);
  sigaddset(set, SIG_IPI);
 +#ifdef SIGIO

Unless there is precedent (which I doubt), do not indent #ifdefs beyond
recognition.

  sigaddset(set, SIGIO);
 +#endif
  sigaddset(set, SIGALRM);
  sigaddset(set, SIGBUS);
  /* SIGINT cannot be handled via signalfd, so that ^C can be used

Otherwise this hunk looks okay.

 diff --git a/os-posix.c b/os-posix.c
 index ba091f1..43f7fec 100644
 --- a/os-posix.c
 +++ b/os-posix.c
 @@ -323,6 +323,9 @@ bool is_daemonized(void)
  
  int os_mlock(void)
  {
 +#if defined(CONFIG_HAIKU)
 +return ENOSYS;

So Haiku does not implement mlock*? That should be explained in the
commit message.

Are you sure that ENOSYS is correct here as opposed to -ENOSYS? :)
BeOS used negative E* codes, POSIX uses positive ones - or the other way
around - and to complicate the matter further, Ingo had written some
Haiku library hack to translate between both versions...

 +#else
  int ret = 0;
  
  ret = mlockall(MCL_CURRENT | MCL_FUTURE);
 @@ -331,4 +334,5 @@ int os_mlock(void)
  }
  
  return ret;
 +#endif
  }
 diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c
 index 16e9d8c..d0ea12a 100644
 --- a/target-xtensa/xtensa-semi.c
 +++ b/target-xtensa/xtensa-semi.c
 @@ -95,59 +95,53 @@ enum {
  
  static uint32_t errno_h2g(int host_errno)
  {
 -static const uint32_t guest_errno[] = {
 -[EPERM] = TARGET_EPERM,
 -[ENOENT]= TARGET_ENOENT,
 -[ESRCH] = TARGET_ESRCH,
 -[EINTR] = TARGET_EINTR,
 -[EIO]   = TARGET_EIO,
 -[ENXIO] = TARGET_ENXIO,
 -[E2BIG] = TARGET_E2BIG,
 -[ENOEXEC]   = TARGET_ENOEXEC,
 -[EBADF] = TARGET_EBADF,
 -[ECHILD]= TARGET_ECHILD,
 -[EAGAIN]= TARGET_EAGAIN,
 -[ENOMEM]= TARGET_ENOMEM,
 -[EACCES]= TARGET_EACCES,
 -[EFAULT]= TARGET_EFAULT,
 +switch (host_errno) {
 +case 0: return 0;
 +case EPERM: return TARGET_EPERM;
 +case ENOENT: return TARGET_ENOENT;
 +case ESRCH: return TARGET_ESRCH;
 +case EINTR: return TARGET_EINTR;
 +case EIO: return TARGET_EIO;
 +case ENXIO: return TARGET_ENXIO;
 +case E2BIG: return TARGET_E2BIG;
 +case ENOEXEC: return TARGET_ENOEXEC;
 +case EBADF: return TARGET_EBADF;
 +case ECHILD: return TARGET_ECHILD;
 +case EAGAIN: return TARGET_EAGAIN;
 +case ENOMEM: return TARGET_ENOMEM;
 +case EACCES: return TARGET_EACCES;
 +case EFAULT: return TARGET_EFAULT;
  #ifdef ENOTBLK
 -[ENOTBLK]   = TARGET_ENOTBLK,
 +case ENOTBLK: return TARGET_ENOTBLK;
  #endif
 -[EBUSY] = TARGET_EBUSY,
 -[EEXIST]= TARGET_EEXIST,
 -[EXDEV] = TARGET_EXDEV,
 -[ENODEV]= TARGET_ENODEV,
 -[ENOTDIR]   = TARGET_ENOTDIR,
 -[EISDIR]= TARGET_EISDIR,
 -[EINVAL]= TARGET_EINVAL,
 -[ENFILE]= TARGET_ENFILE,
 -[EMFILE]= TARGET_EMFILE,
 -[ENOTTY]= TARGET_ENOTTY,
 +case EBUSY: return TARGET_EBUSY;
 +case EEXIST: return TARGET_EEXIST;
 +case EXDEV: return TARGET_EXDEV;
 +case ENODEV: return TARGET_ENODEV;
 +case ENOTDIR: return TARGET_ENOTDIR;
 +case EISDIR: return TARGET_EISDIR;
 +case EINVAL: return TARGET_EINVAL;
 +case ENFILE: return TARGET_ENFILE;
 +case EMFILE: return TARGET_EMFILE;
 +case ENOTTY: return TARGET_ENOTTY;

Why

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Max Filippov

On Wed, Mar 25, 2015 at 1:26 AM, Andreas Färber afaer...@suse.de wrote:
 Am 24.03.2015 um 00:36 schrieb Alexander von Gluck IV:

 diff --git a/target-xtensa/xtensa-semi.c b/target-xtensa/xtensa-semi.c
 index 16e9d8c..d0ea12a 100644
 --- a/target-xtensa/xtensa-semi.c
 +++ b/target-xtensa/xtensa-semi.c
 @@ -95,59 +95,53 @@ enum {

  static uint32_t errno_h2g(int host_errno)
  {
 -static const uint32_t guest_errno[] = {
 -[EPERM] = TARGET_EPERM,
 -[ENOENT]= TARGET_ENOENT,
 -[ESRCH] = TARGET_ESRCH,
 -[EINTR] = TARGET_EINTR,
 -[EIO]   = TARGET_EIO,
 -[ENXIO] = TARGET_ENXIO,
 -[E2BIG] = TARGET_E2BIG,
 -[ENOEXEC]   = TARGET_ENOEXEC,
 -[EBADF] = TARGET_EBADF,
 -[ECHILD]= TARGET_ECHILD,
 -[EAGAIN]= TARGET_EAGAIN,
 -[ENOMEM]= TARGET_ENOMEM,
 -[EACCES]= TARGET_EACCES,
 -[EFAULT]= TARGET_EFAULT,
 +switch (host_errno) {
 +case 0: return 0;
 +case EPERM: return TARGET_EPERM;
 +case ENOENT: return TARGET_ENOENT;
 +case ESRCH: return TARGET_ESRCH;
 +case EINTR: return TARGET_EINTR;
 +case EIO: return TARGET_EIO;
 +case ENXIO: return TARGET_ENXIO;
 +case E2BIG: return TARGET_E2BIG;
 +case ENOEXEC: return TARGET_ENOEXEC;
 +case EBADF: return TARGET_EBADF;
 +case ECHILD: return TARGET_ECHILD;
 +case EAGAIN: return TARGET_EAGAIN;
 +case ENOMEM: return TARGET_ENOMEM;
 +case EACCES: return TARGET_EACCES;
 +case EFAULT: return TARGET_EFAULT;
  #ifdef ENOTBLK
 -[ENOTBLK]   = TARGET_ENOTBLK,
 +case ENOTBLK: return TARGET_ENOTBLK;
  #endif
 -[EBUSY] = TARGET_EBUSY,
 -[EEXIST]= TARGET_EEXIST,
 -[EXDEV] = TARGET_EXDEV,
 -[ENODEV]= TARGET_ENODEV,
 -[ENOTDIR]   = TARGET_ENOTDIR,
 -[EISDIR]= TARGET_EISDIR,
 -[EINVAL]= TARGET_EINVAL,
 -[ENFILE]= TARGET_ENFILE,
 -[EMFILE]= TARGET_EMFILE,
 -[ENOTTY]= TARGET_ENOTTY,
 +case EBUSY: return TARGET_EBUSY;
 +case EEXIST: return TARGET_EEXIST;
 +case EXDEV: return TARGET_EXDEV;
 +case ENODEV: return TARGET_ENODEV;
 +case ENOTDIR: return TARGET_ENOTDIR;
 +case EISDIR: return TARGET_EISDIR;
 +case EINVAL: return TARGET_EINVAL;
 +case ENFILE: return TARGET_ENFILE;
 +case EMFILE: return TARGET_EMFILE;
 +case ENOTTY: return TARGET_ENOTTY;

 Why convert from array to switch statement? It looks like a very
 invasive change for no obvious reason.

I'd be interested to know the reason too, but I'm OK with either way.

  #ifdef ETXTBSY
 -[ETXTBSY]   = TARGET_ETXTBSY,
 +case ETXTBSY: return TARGET_ETXTBSY;
  #endif
 -[EFBIG] = TARGET_EFBIG,
 -[ENOSPC]= TARGET_ENOSPC,
 -[ESPIPE]= TARGET_ESPIPE,
 -[EROFS] = TARGET_EROFS,
 -[EMLINK]= TARGET_EMLINK,
 -[EPIPE] = TARGET_EPIPE,
 -[EDOM]  = TARGET_EDOM,
 -[ERANGE]= TARGET_ERANGE,
 -[ENOSYS]= TARGET_ENOSYS,
 +case EFBIG: return TARGET_EFBIG;
 +case ENOSPC: return TARGET_ENOSPC;
 +case ESPIPE: return TARGET_ESPIPE;
 +case EROFS: return TARGET_EROFS;
 +case EMLINK: return TARGET_EMLINK;
 +case EPIPE: return TARGET_EPIPE;
 +case EDOM: return TARGET_EDOM;
 +case ERANGE: return TARGET_ERANGE;
 +case ENOSYS: return TARGET_ENOSYS;
  #ifdef ELOOP
 -[ELOOP] = TARGET_ELOOP,
 +case ELOOP: return TARGET_ELOOP;
  #endif
  };

No need for semicolon here.

-- 
Thanks.
-- Max

[Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

Re: [Qemu-devel] [PATCH] Haiku: Platform build fixes

7 matches

Site Navigation

Mail list logo

Footer information