Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On Tue, Feb 07, 2017 at 02:25:31PM -0800, Doug Gilmore wrote: > On 02/07/2017 07:14 AM, Stefan Hajnoczi wrote: > > On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: > >> We install this file to data dir but since 0ab8ed18 it's no longer > >> required by any objects during "make". List it explicitly as a depended > >> target of install and fix the broken "make install" command. > >> > >> Signed-off-by: Fam Zheng> >> --- > >> Makefile | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Thanks, applied to my tracing tree: > > https://github.com/stefanha/qemu/commits/tracing > > > > Stefan > > > Are there plans to commit this change? > > AFAICS, ToT builds are broken without this change. Hi Doug, I've been mostly offline due to illness but am back now. The pull request will be sent today. Stefan signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On 02/07/2017 07:14 AM, Stefan Hajnoczi wrote: > On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: >> We install this file to data dir but since 0ab8ed18 it's no longer >> required by any objects during "make". List it explicitly as a depended >> target of install and fix the broken "make install" command. >> >> Signed-off-by: Fam Zheng>> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks, applied to my tracing tree: > https://github.com/stefanha/qemu/commits/tracing > > Stefan > Are there plans to commit this change? AFAICS, ToT builds are broken without this change. Thanks, Doug
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. > > Signed-off-by: Fam Zheng> --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On 02/04/2017 03:32 PM, Fam Zheng wrote: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. > > Signed-off-by: Fam ZhengTested-by: Christian Borntraeger > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 4b72a4c..b993741 100644 > --- a/Makefile > +++ b/Makefile > @@ -589,7 +589,7 @@ endif > endif > > > -install: all $(if $(BUILD_DOCS),install-doc) \ > +install: all $(if $(BUILD_DOCS),install-doc) $(BUILD_DIR)/trace-events-all \ > install-datadir install-localstatedir > ifneq ($(TOOLS),) > $(call install-prog,$(subst > qemu-ga,qemu-ga$(EXESUF),$(TOOLS)),$(DESTDIR)$(bindir)) >
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. > > Signed-off-by: Fam Zheng> --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o-http://search.cpan.org/~danberr/ :|
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
On Sun, Feb 05, 2017 at 12:39:45AM +0200, Lluís Vilanova wrote: > Fam Zheng writes: > > > We install this file to data dir but since 0ab8ed18 it's no longer > > required by any objects during "make". List it explicitly as a depended > > target of install and fix the broken "make install" command. > > I'm probably wrong, but I remember someone worked on making traces > self-descriptive, so that simpletrace would no longer need access to the > generated trace-events-all file. > > If the file is really never used, then all stray rules to generate it should > be > removed, as well as its installation. It is used at runtime when analysing a simpletrace file. While it would be nice if they were self-descriptive, that isn't the case today, so we must install this file. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o-http://search.cpan.org/~danberr/ :|
Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
Fam Zheng writes: > We install this file to data dir but since 0ab8ed18 it's no longer > required by any objects during "make". List it explicitly as a depended > target of install and fix the broken "make install" command. I'm probably wrong, but I remember someone worked on making traces self-descriptive, so that simpletrace would no longer need access to the generated trace-events-all file. If the file is really never used, then all stray rules to generate it should be removed, as well as its installation. Cheers, Lluis
[Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
We install this file to data dir but since 0ab8ed18 it's no longer required by any objects during "make". List it explicitly as a depended target of install and fix the broken "make install" command. Signed-off-by: Fam Zheng--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4b72a4c..b993741 100644 --- a/Makefile +++ b/Makefile @@ -589,7 +589,7 @@ endif endif -install: all $(if $(BUILD_DOCS),install-doc) \ +install: all $(if $(BUILD_DOCS),install-doc) $(BUILD_DIR)/trace-events-all \ install-datadir install-localstatedir ifneq ($(TOOLS),) $(call install-prog,$(subst qemu-ga,qemu-ga$(EXESUF),$(TOOLS)),$(DESTDIR)$(bindir)) -- 2.9.3