Re: [Qemu-devel] [PATCH] RDMA: Missing free in (probably unreachable) error path

[Juan Quintela]

"Dr. David Alan Gilbert (git)"  wrote:
> From: "Dr. David Alan Gilbert" 
>
> Coverity CID 1307773
>
> Signed-off-by: Dr. David Alan Gilbert 

Integrated gonglei patch for this, just moved the malloc.

> ---
>  migration/rdma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 53e611e..2a9e0ce 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -3395,6 +3395,7 @@ static void *qemu_fopen_rdma(RDMAContext *rdma, const 
> char *mode)
>  QEMUFileRDMA *r = g_malloc0(sizeof(QEMUFileRDMA));
>  
>  if (qemu_file_mode_is_not_valid(mode)) {
> +g_free(r);
>  return NULL;
>  }

Re: [Qemu-devel] [PATCH] RDMA: Missing free in (probably unreachable) error path

[Andreas Färber]

Am 22.06.2015 um 17:18 schrieb Dr. David Alan Gilbert (git):
> From: "Dr. David Alan Gilbert" 
> 
> Coverity CID 1307773
> 
> Signed-off-by: Dr. David Alan Gilbert 

Reviewed-by: Andreas Färber 

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)

[Qemu-devel] [PATCH] RDMA: Missing free in (probably unreachable) error path

[Dr. David Alan Gilbert (git)]

From: "Dr. David Alan Gilbert" 

Coverity CID 1307773

Signed-off-by: Dr. David Alan Gilbert 
---
 migration/rdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 53e611e..2a9e0ce 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3395,6 +3395,7 @@ static void *qemu_fopen_rdma(RDMAContext *rdma, const 
char *mode)
 QEMUFileRDMA *r = g_malloc0(sizeof(QEMUFileRDMA));
 
 if (qemu_file_mode_is_not_valid(mode)) {
+g_free(r);
 return NULL;
 }
 
-- 
2.4.3