Re: [Qemu-devel] [PATCH] block.c typo in comment fixed

[Matthias]

On 11/01/2011 08:39 AM, Stefan Hajnoczi wrote:

On Tue, Nov 01, 2011 at 01:36:42AM +, matthias@googlemail.com wrote:

From: Matthias Brugger


Signed-off-by: Matthias Brugger
---
  block.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


"Writable" is also a common spelling.  Try git grep writable and compare
against git grep writeable.  In qemu.git "writable" actually dominates
by a large majority so we should leave this alone.

Stefan


Alright, I didn't know that. Sorry for the noise.

Regards,
Matthias

--
---
http://motzblog.wordpress.com/

Re: [Qemu-devel] [PATCH] block.c typo in comment fixed

[Stefan Hajnoczi]

On Tue, Nov 01, 2011 at 01:36:42AM +, matthias@googlemail.com wrote:
> From: Matthias Brugger 
> 
> 
> Signed-off-by: Matthias Brugger 
> ---
>  block.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

"Writable" is also a common spelling.  Try git grep writable and compare
against git grep writeable.  In qemu.git "writable" actually dominates
by a large majority so we should leave this alone.

Stefan

Re: [Qemu-devel] [PATCH] block.c typo in comment fixed

[Stefan Weil]

Am 01.11.2011 02:36, schrieb matthias@googlemail.com:

From: Matthias Brugger


Signed-off-by: Matthias Brugger
---
  block.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 9bb236c..480aae2 100644
--- a/block.c
+++ b/block.c
@@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const 
char *filename,
  open_flags = flags&  ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);

  /*
- * Snapshots should be writable.
+ * Snapshots should be writeable.
   */
  if (bs->is_temporary) {
  open_flags |= BDRV_O_RDWR;


Hi Matthias,

both writable and writeable seem to be correct,
but http://oxforddictionaries.com/ says that writable is the only
correct spelling.

Therefore your patch should not be used.

Cheers,
Stefan

[Qemu-devel] [PATCH] block.c typo in comment fixed

[matthias . bgg]

From: Matthias Brugger 


Signed-off-by: Matthias Brugger 
---
 block.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 9bb236c..480aae2 100644
--- a/block.c
+++ b/block.c
@@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const 
char *filename,
 open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
 
 /*
- * Snapshots should be writable.
+ * Snapshots should be writeable.
  */
 if (bs->is_temporary) {
 open_flags |= BDRV_O_RDWR;
-- 
1.7.1