Re: [Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs
> On Mar 21, 2017, at 1:37 PM, Peter Maydellwrote: > > On 16 March 2017 at 11:14, Vinzenz 'evilissimo' Feenstra > wrote: >> From: Vinzenz Feenstra >> >> When importing dynamically functions via `GetProcAddress` in windows >> related code, it is quite common to make a typedef for the resulting >> function pointer. When the function to be imported, has a stdcall >> calling convention, usually the `WINAPI` macro is used. This patch adds an >> exception in the checkpatch.pl script to allow the calling convention >> specification in function pointer typedefs, to be `WINAPI`. >> >> Signed-off-by: Vinzenz Feenstra > > Could you provide an example of the kind of source line that provokes > the incorrect warning and the checkpatch output that results, > please? Hmm I just realize that it is working now, but I figured out now what is the real problem and that my patch is wrong. Please discard this patch and thanks for making me think again :-) > > thanks > -- PMM
Re: [Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs
On 16 March 2017 at 11:14, Vinzenz 'evilissimo' Feenstrawrote: > From: Vinzenz Feenstra > > When importing dynamically functions via `GetProcAddress` in windows > related code, it is quite common to make a typedef for the resulting > function pointer. When the function to be imported, has a stdcall > calling convention, usually the `WINAPI` macro is used. This patch adds an > exception in the checkpatch.pl script to allow the calling convention > specification in function pointer typedefs, to be `WINAPI`. > > Signed-off-by: Vinzenz Feenstra Could you provide an example of the kind of source line that provokes the incorrect warning and the checkpatch output that results, please? thanks -- PMM
[Qemu-devel] [PATCH] checkpatch: Supress warning in function pointer typedefs
From: Vinzenz FeenstraWhen importing dynamically functions via `GetProcAddress` in windows related code, it is quite common to make a typedef for the resulting function pointer. When the function to be imported, has a stdcall calling convention, usually the `WINAPI` macro is used. This patch adds an exception in the checkpatch.pl script to allow the calling convention specification in function pointer typedefs, to be `WINAPI`. Signed-off-by: Vinzenz Feenstra --- scripts/checkpatch.pl | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f084542..33bf585 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1774,7 +1774,14 @@ sub process { # likely a typedef for a function. } elsif ($ctx =~ /$Type$/) { - } else { +# If this is a typedef we need to allow WINAPI as a calling +# convention. Even though there should be only one space around the +# star, we allow none or any, to suppress the following warning. +# The check for the number of spaces around the star is checked +# elsewhere. + } elsif($ctx =~ /^\s*typedef\s+$Type\(WINAPI\s*\*\s*$Ident\)/) { + +} else { ERROR("space prohibited between function name and open parenthesis '('\n" . $herecurr); } } -- 2.9.3