Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
On Sat, Apr 09, 2016 at 05:18:01PM +0800, Cao jin wrote: > ping? I will add this to the machine queue for 2.7. > On 03/16/2016 04:00 AM, Eduardo Habkost wrote: > >On Mon, Mar 14, 2016 at 01:42:06PM +0800, Cao jin wrote: > >>Hi, > >> Is anyone gonna take this one? > > > >Not sure which tree this should go. Michael, Igor, if you expect > >this to go through the Machine Core tree, please let me know. > > > > -- > Yours Sincerely, > > Cao jin > > -- Eduardo
Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
ping? On 03/16/2016 04:00 AM, Eduardo Habkost wrote: On Mon, Mar 14, 2016 at 01:42:06PM +0800, Cao jin wrote: Hi, Is anyone gonna take this one? Not sure which tree this should go. Michael, Igor, if you expect this to go through the Machine Core tree, please let me know. -- Yours Sincerely, Cao jin
Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
On Mon, Mar 14, 2016 at 01:42:06PM +0800, Cao jin wrote: > Hi, > Is anyone gonna take this one? Not sure which tree this should go. Michael, Igor, if you expect this to go through the Machine Core tree, please let me know. -- Eduardo
Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
Hi, Is anyone gonna take this one? On 03/03/2016 09:59 PM, Igor Mammedov wrote: On Thu, 3 Mar 2016 17:24:12 +0800 Cao jin wrote: correct comment and remove an unused macro. commit adcb4ee6 already correct its type Signed-off-by: Cao jin Reviewed-by: Igor Mammedov -- Yours Sincerely, Cao jin
Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
On 03/03/2016 09:59 PM, Igor Mammedov wrote: On Thu, 3 Mar 2016 17:24:12 +0800 Cao jin wrote: correct comment and remove an unused macro. commit adcb4ee6 already correct its type Signed-off-by: Cao jin Reviewed-by: Igor Mammedov --- Btw, in pc_memory_init(), I don`t see in which condition, the following code will be executed: if ((pcms->hotplug_memory.base + hotplug_mem_size) < hotplug_mem_size) { error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT, machine->maxram_size); exit(EXIT_FAILURE); } I appreciate if anyone could give a hint Integer overflow? Ah yes, make sense. Thanks very much for the hint -- Yours Sincerely, Cao jin
Re: [Qemu-devel] [PATCH] correct comment of MemoryHotplugState
On Thu, 3 Mar 2016 17:24:12 +0800 Cao jin wrote: > correct comment and remove an unused macro. commit adcb4ee6 already > correct its type > > Signed-off-by: Cao jin Reviewed-by: Igor Mammedov > --- > Btw, in pc_memory_init(), I don`t see in which condition, the following code > will be executed: > > if ((pcms->hotplug_memory.base + hotplug_mem_size) < > hotplug_mem_size) { > error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT, > machine->maxram_size); > exit(EXIT_FAILURE); > } > > I appreciate if anyone could give a hint Integer overflow? > > And PS: the output of *get_maintainer.pl this_patch* isn`t the same as > *get_maintainer.pl -f include/hw/mem/pc-dimm.h*. > I am not sure if it is a problem. > > include/hw/mem/pc-dimm.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h > index 218dfb0..8cdc326 100644 > --- a/include/hw/mem/pc-dimm.h > +++ b/include/hw/mem/pc-dimm.h > @@ -20,8 +20,6 @@ > #include "sysemu/hostmem.h" > #include "hw/qdev.h" > > -#define DEFAULT_PC_DIMMSIZE (1024*1024*1024) > - > #define TYPE_PC_DIMM "pc-dimm" > #define PC_DIMM(obj) \ > OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM) > @@ -72,7 +70,7 @@ typedef struct PCDIMMDeviceClass { > > /** > * MemoryHotplugState: > - * @base: address in guest RAM address space where hotplug memory > + * @base: address in guest physical address space where hotplug memory > * address space begins. > * @mr: hotplug memory address space container > */
[Qemu-devel] [PATCH] correct comment of MemoryHotplugState
correct comment and remove an unused macro. commit adcb4ee6 already correct its type Signed-off-by: Cao jin --- Btw, in pc_memory_init(), I don`t see in which condition, the following code will be executed: if ((pcms->hotplug_memory.base + hotplug_mem_size) < hotplug_mem_size) { error_report("unsupported amount of maximum memory: " RAM_ADDR_FMT, machine->maxram_size); exit(EXIT_FAILURE); } I appreciate if anyone could give a hint And PS: the output of *get_maintainer.pl this_patch* isn`t the same as *get_maintainer.pl -f include/hw/mem/pc-dimm.h*. I am not sure if it is a problem. include/hw/mem/pc-dimm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index 218dfb0..8cdc326 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -20,8 +20,6 @@ #include "sysemu/hostmem.h" #include "hw/qdev.h" -#define DEFAULT_PC_DIMMSIZE (1024*1024*1024) - #define TYPE_PC_DIMM "pc-dimm" #define PC_DIMM(obj) \ OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM) @@ -72,7 +70,7 @@ typedef struct PCDIMMDeviceClass { /** * MemoryHotplugState: - * @base: address in guest RAM address space where hotplug memory + * @base: address in guest physical address space where hotplug memory * address space begins. * @mr: hotplug memory address space container */ -- 2.1.0