Re: [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message

2011-11-21 Thread Andreas Färber 
Am 19.11.2011 20:18, schrieb Stefan Weil:
 This was spotted by cppcheck.
 
 Signed-off-by: Stefan Weil s...@weilnetz.de
 ---
  darwin-user/signal.c |3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)
 
 diff --git a/darwin-user/signal.c b/darwin-user/signal.c
 index c530227..317ef92 100644
 --- a/darwin-user/signal.c
 +++ b/darwin-user/signal.c
 @@ -270,8 +270,7 @@ int do_sigaction(int sig, const struct sigaction *act,
  host_sig = target_to_host_signal(sig);
  if (host_sig != SIGSEGV  host_sig != SIGBUS) {
  #if defined(DEBUG_SIGNAL)
 -fprintf(stderr, sigaction handler going to call sigaction\n,
 -act-sa_handler, act-sa_flags, act-sa_mask);
 +fprintf(stderr, sigaction handler going to call sigaction\n);
  #endif
  
  sigfillset(act1.sa_mask);

Is the debug output really useful without the information? Maybe rather
append %p %x %x? What does linux-user do?

Andreas

Re: [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message

2011-11-21 Thread Peter Maydell 
On 21 November 2011 13:32, Andreas Färber andreas.faer...@web.de wrote:
 Is the debug output really useful without the information? Maybe rather
 append %p %x %x? What does linux-user do?

linux-user doesn't print any debug output at this point.

Incidentally, I'm increasingly of the opinion that the various minor
foo-user subtrees would be better off merged into a single user tree:
there is a steady stream of minor bugfixes/feature improvements that
go into linux-user that don't get into the others...

-- PMM

[Qemu-devel] [PATCH] darwin-user: Fix format string in debug message

2011-11-19 Thread Stefan Weil 
This was spotted by cppcheck.

Signed-off-by: Stefan Weil s...@weilnetz.de
---
 darwin-user/signal.c |3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/darwin-user/signal.c b/darwin-user/signal.c
index c530227..317ef92 100644
--- a/darwin-user/signal.c
+++ b/darwin-user/signal.c
@@ -270,8 +270,7 @@ int do_sigaction(int sig, const struct sigaction *act,
 host_sig = target_to_host_signal(sig);
 if (host_sig != SIGSEGV  host_sig != SIGBUS) {
 #if defined(DEBUG_SIGNAL)
-fprintf(stderr, sigaction handler going to call sigaction\n,
-act-sa_handler, act-sa_flags, act-sa_mask);
+fprintf(stderr, sigaction handler going to call sigaction\n);
 #endif
 
 sigfillset(act1.sa_mask);
-- 
1.7.2.5