[Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor

2013-06-03 Thread Anthony Liguori
It's not a GObject.

Cc: Gerd Hoffman kra...@redhat.com
Reported-by: Michael Tokarev m...@tls.msk.ru
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
 ui/gtk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 8dc9041..3bc2842 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
 pixbuf, c-hot_x, c-hot_y);
 gdk_window_set_cursor(gtk_widget_get_window(s-drawing_area), cursor);
 g_object_unref(pixbuf);
-g_object_unref(cursor);
+gdk_cursor_unref(cursor);
 }
 
 static void gd_switch(DisplayChangeListener *dcl,
-- 
1.8.0




Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor

2013-06-03 Thread Peter Maydell
On 3 June 2013 21:39, Anthony Liguori aligu...@us.ibm.com wrote:
 It's not a GObject.

 Cc: Gerd Hoffman kra...@redhat.com
 Reported-by: Michael Tokarev m...@tls.msk.ru
 Signed-off-by: Anthony Liguori aligu...@us.ibm.com
 ---
  ui/gtk.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/ui/gtk.c b/ui/gtk.c
 index 8dc9041..3bc2842 100644
 --- a/ui/gtk.c
 +++ b/ui/gtk.c
 @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
  pixbuf, c-hot_x, c-hot_y);
  gdk_window_set_cursor(gtk_widget_get_window(s-drawing_area), cursor);
  g_object_unref(pixbuf);
 -g_object_unref(cursor);
 +gdk_cursor_unref(cursor);

Function name in subject doesn't match code change :-)

-- PMM



Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor

2013-06-03 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes:

 On 3 June 2013 21:39, Anthony Liguori aligu...@us.ibm.com wrote:
 It's not a GObject.

 Cc: Gerd Hoffman kra...@redhat.com
 Reported-by: Michael Tokarev m...@tls.msk.ru
 Signed-off-by: Anthony Liguori aligu...@us.ibm.com
 ---
  ui/gtk.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/ui/gtk.c b/ui/gtk.c
 index 8dc9041..3bc2842 100644
 --- a/ui/gtk.c
 +++ b/ui/gtk.c
 @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
  pixbuf, c-hot_x, c-hot_y);
  gdk_window_set_cursor(gtk_widget_get_window(s-drawing_area), cursor);
  g_object_unref(pixbuf);
 -g_object_unref(cursor);
 +gdk_cursor_unref(cursor);

 Function name in subject doesn't match code change :-)

Doh, ack.

Regards,

Anthony Liguori


 -- PMM