Re: [Qemu-devel] [PATCH] linux-user: fix GPROF build failure
On 02/05/2019 11:27, Alex Bennée wrote: When linux-user/exit was introduced we failed to move the gprof include at the same time. The CI didn't notice because it only builds system emulation. Fix it for those that still find gprof useful. Signed-off-by: Alex Bennée --- linux-user/exit.c| 3 +++ linux-user/syscall.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/exit.c b/linux-user/exit.c index 14e94e28fa..bdda720553 100644 --- a/linux-user/exit.c +++ b/linux-user/exit.c @@ -18,6 +18,9 @@ */ #include "qemu/osdep.h" #include "qemu.h" +#ifdef TARGET_GPROF +#include +#endif #ifdef CONFIG_GCOV extern void __gcov_dump(void); diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 96cd4bf86d..f2d9883aef 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -59,9 +59,6 @@ #ifdef CONFIG_TIMERFD #include #endif -#ifdef TARGET_GPROF -#include -#endif #ifdef CONFIG_EVENTFD #include #endif Applied to my linux-user branch. Thanks, Laurent
Re: [Qemu-devel] [PATCH] linux-user: fix GPROF build failure
Laurent Desnogues writes: > Hello, > > On Thu, May 2, 2019 at 11:31 AM Alex Bennée wrote: >> >> When linux-user/exit was introduced we failed to move the gprof >> include at the same time. The CI didn't notice because it only builds >> system emulation. Fix it for those that still find gprof useful. >> >> Signed-off-by: Alex Bennée > > Tested-by: Laurent Desnogues Sadly running programs then fails because of the SIG_PROF signal getting passed to the guest. I wonder how this ever worked? -- Alex Bennée
Re: [Qemu-devel] [PATCH] linux-user: fix GPROF build failure
Hello, On Thu, May 2, 2019 at 11:31 AM Alex Bennée wrote: > > When linux-user/exit was introduced we failed to move the gprof > include at the same time. The CI didn't notice because it only builds > system emulation. Fix it for those that still find gprof useful. > > Signed-off-by: Alex Bennée Tested-by: Laurent Desnogues Thanks, Laurent > --- > linux-user/exit.c| 3 +++ > linux-user/syscall.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/linux-user/exit.c b/linux-user/exit.c > index 14e94e28fa..bdda720553 100644 > --- a/linux-user/exit.c > +++ b/linux-user/exit.c > @@ -18,6 +18,9 @@ > */ > #include "qemu/osdep.h" > #include "qemu.h" > +#ifdef TARGET_GPROF > +#include > +#endif > > #ifdef CONFIG_GCOV > extern void __gcov_dump(void); > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 96cd4bf86d..f2d9883aef 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -59,9 +59,6 @@ > #ifdef CONFIG_TIMERFD > #include > #endif > -#ifdef TARGET_GPROF > -#include > -#endif > #ifdef CONFIG_EVENTFD > #include > #endif > -- > 2.20.1 > >
[Qemu-devel] [PATCH] linux-user: fix GPROF build failure
When linux-user/exit was introduced we failed to move the gprof include at the same time. The CI didn't notice because it only builds system emulation. Fix it for those that still find gprof useful. Signed-off-by: Alex Bennée --- linux-user/exit.c| 3 +++ linux-user/syscall.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/exit.c b/linux-user/exit.c index 14e94e28fa..bdda720553 100644 --- a/linux-user/exit.c +++ b/linux-user/exit.c @@ -18,6 +18,9 @@ */ #include "qemu/osdep.h" #include "qemu.h" +#ifdef TARGET_GPROF +#include +#endif #ifdef CONFIG_GCOV extern void __gcov_dump(void); diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 96cd4bf86d..f2d9883aef 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -59,9 +59,6 @@ #ifdef CONFIG_TIMERFD #include #endif -#ifdef TARGET_GPROF -#include -#endif #ifdef CONFIG_EVENTFD #include #endif -- 2.20.1
