[Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-05-29 Thread Ed Maste
Based on the datasheet at
http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf

Signed-off-by: Ed Maste 
---
 hw/block/m25p80.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 759c84d..a927a6b 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -123,6 +123,7 @@ static const FlashPartInfo known_devices[] = {
 { INFO("mx25l25655e", 0xc22619,  0,  64 << 10, 512, 0) },
 
 /* Micron */
+{ INFO("n25q032a",0x20bb16,  0,  64 << 10,  64, ER_4K) },
 { INFO("n25q128a11",  0x20bb18,  0,  64 << 10, 256, 0) },
 { INFO("n25q128a13",  0x20ba18,  0,  64 << 10, 256, 0) },
 { INFO("n25q256a",0x20ba19,  0,  64 << 10, 512, ER_4K) },
-- 
1.7.11.5




Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Peter Crosthwaite
Hi Ed,

On Wed, May 29, 2013 at 11:58 PM, Ed Maste  wrote:
> Based on the datasheet at
> http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
>
> Signed-off-by: Ed Maste 
> ---
>  hw/block/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 759c84d..a927a6b 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -123,6 +123,7 @@ static const FlashPartInfo known_devices[] = {
>  { INFO("mx25l25655e", 0xc22619,  0,  64 << 10, 512, 0) },
>
>  /* Micron */
> +{ INFO("n25q032a",0x20bb16,  0,  64 << 10,  64, ER_4K) },

Does this have a11 and a13 variants as well?

>  { INFO("n25q128a11",  0x20bb18,  0,  64 << 10, 256, 0) },
>  { INFO("n25q128a13",  0x20ba18,  0,  64 << 10, 256, 0) },

And this looks odd, these parts don't support 4K erase as well?

Regards,
Peter

>  { INFO("n25q256a",0x20ba19,  0,  64 << 10, 512, ER_4K) },
> --
> 1.7.11.5
>
>



Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a

2013-06-04 Thread Ed Maste
On 4 June 2013 07:31, Peter Crosthwaite  wrote:
>>  /* Micron */
>> +{ INFO("n25q032a",0x20bb16,  0,  64 << 10,  64, ER_4K) },
>
> Does this have a11 and a13 variants as well?
>
>>  { INFO("n25q128a11",  0x20bb18,  0,  64 << 10, 256, 0) },
>>  { INFO("n25q128a13",  0x20ba18,  0,  64 << 10, 256, 0) },
>
> And this looks odd, these parts don't support 4K erase as well?

You're correct on both counts - I originally added the n25q032a based
on the n25q256a entry, then sync'd the list with the one from the
Linux kernel, and it's missing the 4K sector erase flag.  I'll send a
followup patch to update all of the Micron entries.