Re: [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

[Michael Tokarev]

04.09.2015 22:41, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau 
> 
> The legacy<> type is no longer used since 7ce7ffe02.

Applied to -trivial, with the typo fix suggested by Eric.

Thanks,

/mjt

[Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

[marcandre . lureau]

From: Marc-André Lureau 

The legacy<> type is no longer used since 7ce7ffe02.

Signed-off-by: Marc-André Lureau 
---
 qapi-schema.json | 15 ++-
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 67fef37..884d476 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1632,13 +1632,10 @@
 #1) A primitive type such as 'u8', 'u16', 'bool', 'str', or 'double'.
 #   These types are mapped to the appropriate JSON type.
 #
-#2) A legacy type in the form 'legacy' where subtype is the
-#   legacy qdev typename.  These types are always treated as strings.
-#
-#3) A child type in the form 'child' where subtype is a qdev
+#2) A child type in the form 'child' where subtype is a qdev
 #   device type name.  Child properties create the composition tree.
 #
-#4) A link type in the form 'link' where subtype is a qdev
+#3) A link type in the form 'link' where subtype is a qdev
 #   device type name.  Link properties form the device model graph.
 #
 # Since: 1.2
@@ -1689,10 +1686,10 @@
 #
 # @property: The property name to read
 #
-# Returns: The property value.  The type depends on the property type.  
legacy<>
-#  properties are returned as #str.  child<> and link<> properties are
-#  returns as #str pathnames.  All integer property types (u8, u16, 
etc)
-#  are returned as #int.
+# Returns: The property value.  The type depends on the property
+#  type. child<> and link<> properties are returns as #str
+#  pathnames.  All integer property types (u8, u16, etc) are
+#  returned as #int.
 #
 # Since: 1.2
 ##
-- 
2.4.3

Re: [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc

[Eric Blake]

On 09/04/2015 01:41 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau 
> 
> The legacy<> type is no longer used since 7ce7ffe02.
> 
> Signed-off-by: Marc-André Lureau 
> ---
>  qapi-schema.json | 15 ++-
>  1 file changed, 6 insertions(+), 9 deletions(-)

> @@ -1689,10 +1686,10 @@
>  #
>  # @property: The property name to read
>  #
> -# Returns: The property value.  The type depends on the property type.  
> legacy<>
> -#  properties are returned as #str.  child<> and link<> properties 
> are
> -#  returns as #str pathnames.  All integer property types (u8, u16, 
> etc)
> -#  are returned as #int.
> +# Returns: The property value.  The type depends on the property
> +#  type. child<> and link<> properties are returns as #str

While at it, please fix the pre-existing typo:

s/returns/returned/

> +#  pathnames.  All integer property types (u8, u16, etc) are
> +#  returned as #int.

With that fixed,
Reviewed-by: Eric Blake 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature