Re: [Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Eric Johnson
Hi Yongbok,

You need to make Status.MX writeable as well.

- .CP0_Status_rw_bitmask = 0x3678FF1F,
+ .CP0_Status_rw_bitmask = 0x3778FF1F,

-Eric

> -Original Message-
> From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org 
> [mailto:qemu-devel-
> bounces+eric.johnson=imgtec@nongnu.org] On Behalf Of Yongbok Kim
> Sent: Thursday, August 01, 2013 3:35 AM
> To: qemu-devel@nongnu.org
> Cc: Yongbok Kim; Cristian Cuna; Leon Alrae; aurel...@aurel32.net
> Subject: [Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE
> 
> 34Kf core does support DSP ASE.
> CP0_Config3 configuration for 34Kf and description are wrong.
> 
> Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet
> 
> Signed-off-by: Yongbok Kim 
> ---
>  target-mips/translate_init.c |5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c
> index 7cf238f..4cd9ed5 100644
> --- a/target-mips/translate_init.c
> +++ b/target-mips/translate_init.c
> @@ -274,14 +274,13 @@ static const mips_def_t mips_defs[] =
> (0 << CP0C1_DS) | (3 << CP0C1_DL) | (1 << CP0C1_DA) |
> (1 << CP0C1_CA),
>  .CP0_Config2 = MIPS_CONFIG2,
> -.CP0_Config3 = MIPS_CONFIG3 | (1 << CP0C3_VInt) | (1 << CP0C3_MT),
> +.CP0_Config3 = MIPS_CONFIG3 | (1 << CP0C3_VInt) | (1 << CP0C3_MT) |
> +   (1 << CP0C3_DSPP),
>  .CP0_LLAddr_rw_bitmask = 0,
>  .CP0_LLAddr_shift = 0,
>  .SYNCI_Step = 32,
>  .CCRes = 2,
> -/* No DSP implemented. */
>  .CP0_Status_rw_bitmask = 0x3678FF1F,
> -/* No DSP implemented. */
>  .CP0_TCStatus_rw_bitmask = (0 << CP0TCSt_TCU3) | (0 << CP0TCSt_TCU2) 
> |
>  (1 << CP0TCSt_TCU1) | (1 << CP0TCSt_TCU0) |
>  (0 << CP0TCSt_TMX) | (1 << CP0TCSt_DT) |
> --
> 1.7.4
> 
> 



[Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Yongbok Kim
34Kf core does support DSP ASE.
CP0_Config3 configuration for 34Kf and description are wrong.

Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet

Signed-off-by: Yongbok Kim 
---
 target-mips/translate_init.c |5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c
index 7cf238f..4cd9ed5 100644
--- a/target-mips/translate_init.c
+++ b/target-mips/translate_init.c
@@ -274,14 +274,13 @@ static const mips_def_t mips_defs[] =
(0 << CP0C1_DS) | (3 << CP0C1_DL) | (1 << CP0C1_DA) |
(1 << CP0C1_CA),
 .CP0_Config2 = MIPS_CONFIG2,
-.CP0_Config3 = MIPS_CONFIG3 | (1 << CP0C3_VInt) | (1 << CP0C3_MT),
+.CP0_Config3 = MIPS_CONFIG3 | (1 << CP0C3_VInt) | (1 << CP0C3_MT) |
+   (1 << CP0C3_DSPP),
 .CP0_LLAddr_rw_bitmask = 0,
 .CP0_LLAddr_shift = 0,
 .SYNCI_Step = 32,
 .CCRes = 2,
-/* No DSP implemented. */
 .CP0_Status_rw_bitmask = 0x3678FF1F,
-/* No DSP implemented. */
 .CP0_TCStatus_rw_bitmask = (0 << CP0TCSt_TCU3) | (0 << CP0TCSt_TCU2) |
 (1 << CP0TCSt_TCU1) | (1 << CP0TCSt_TCU0) |
 (0 << CP0TCSt_TMX) | (1 << CP0TCSt_DT) |
-- 
1.7.4