Re: [Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT

[Leon Alrae]

On 01/07/2015 14:59, Aurelien Jarno wrote:
 When syncing the task ASID with EntryHi, correctly or the value instead
 of assigning it.
 
 Reported-by: Dr. David Alan Gilbert dgilb...@redhat.com
 Signed-off-by: Aurelien Jarno aurel...@aurel32.net
 Cc: Leon Alrae leon.al...@imgtec.com
 ---
  target-mips/op_helper.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Leon Alrae leon.al...@imgtec.com

Thanks,
Leon

(FYI, I just returned from holidays and I'm starting preparing a pull request
targeting -rc1 as probably is a bit too late for -rc0...)

[Qemu-devel] [PATCH] target-mips: fix ASID synchronisation for MIPS MT

[Aurelien Jarno]

When syncing the task ASID with EntryHi, correctly or the value instead
of assigning it.

Reported-by: Dr. David Alan Gilbert dgilb...@redhat.com
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
Cc: Leon Alrae leon.al...@imgtec.com
---
 target-mips/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 2a9ddff..d457a29 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -661,7 +661,7 @@ static void sync_c0_tcstatus(CPUMIPSState *cpu, int tc,
 
 /* Sync the TASID with EntryHi.  */
 cpu-CP0_EntryHi = ~0xff;
-cpu-CP0_EntryHi = tasid;
+cpu-CP0_EntryHi |= tasid;
 
 compute_hflags(cpu);
 }
-- 
2.1.4