Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

[Max Reitz]

On 06.09.19 13:39, Thomas Huth wrote:
> When running "make check -j8" or something similar, the iotests are
> running in parallel with the other tests. So when they are printing
> out "Passed all xx tests" or a similar status message at the end,
> it might not be quite clear that this message belongs to the iotests,
> since the output might be mixed with the other tests. Thus change the
> word "tests" here to "iotests" instead to avoid confusion.
> 
> Signed-off-by: Thomas Huth 
> ---
>  tests/qemu-iotests/check | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

[John Snow]

On 9/6/19 7:39 AM, Thomas Huth wrote:
> When running "make check -j8" or something similar, the iotests are
> running in parallel with the other tests. So when they are printing
> out "Passed all xx tests" or a similar status message at the end,
> it might not be quite clear that this message belongs to the iotests,
> since the output might be mixed with the other tests. Thus change the
> word "tests" here to "iotests" instead to avoid confusion.
> 
> Signed-off-by: Thomas Huth 

Yeah, why not? Being explicit is nice.

Reviewed-by: John Snow 

> ---
>  tests/qemu-iotests/check | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index c24874ff4a..2f1cf72abc 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -694,12 +694,12 @@ END{ if (NR > 0) {
>  if [ ! -z "$n_bad" -a $n_bad != 0 ]
>  then
>  echo "Failures:$bad"
> -echo "Failed $n_bad of $try tests"
> +echo "Failed $n_bad of $try iotests"
>  echo "Failures:$bad" | fmt >>check.log
> -echo "Failed $n_bad of $try tests" >>check.log
> +echo "Failed $n_bad of $try iotests" >>check.log
>  else
> -echo "Passed all $try tests"
> -echo "Passed all $try tests" >>check.log
> +echo "Passed all $try iotests"
> +echo "Passed all $try iotests" >>check.log
>  fi
>  needwrap=false
>  fi
> 

[Qemu-devel] [PATCH] tests/qemu-iotests/check: Replace "tests" with "iotests" in final status text

[Thomas Huth]

When running "make check -j8" or something similar, the iotests are
running in parallel with the other tests. So when they are printing
out "Passed all xx tests" or a similar status message at the end,
it might not be quite clear that this message belongs to the iotests,
since the output might be mixed with the other tests. Thus change the
word "tests" here to "iotests" instead to avoid confusion.

Signed-off-by: Thomas Huth 
---
 tests/qemu-iotests/check | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index c24874ff4a..2f1cf72abc 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -694,12 +694,12 @@ END{ if (NR > 0) {
 if [ ! -z "$n_bad" -a $n_bad != 0 ]
 then
 echo "Failures:$bad"
-echo "Failed $n_bad of $try tests"
+echo "Failed $n_bad of $try iotests"
 echo "Failures:$bad" | fmt >>check.log
-echo "Failed $n_bad of $try tests" >>check.log
+echo "Failed $n_bad of $try iotests" >>check.log
 else
-echo "Passed all $try tests"
-echo "Passed all $try tests" >>check.log
+echo "Passed all $try iotests"
+echo "Passed all $try iotests" >>check.log
 fi
 needwrap=false
 fi
-- 
2.18.1