Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-04-28 Thread Stefan Berger 

On 4/24/19 5:45 AM, Thomas Huth wrote:

Since we do not use gtester anymore (which had a bug here),
we can now use g_test_skip() to mark skipped tests.

Signed-off-by: Thomas Huth 

Reviewed-by: Stefan Berger 

---
  tests/tpm-tests.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 582ec0cfd4..e640777aa9 100644
--- a/tests/tpm-tests.c
+++ b/tests/tpm-tests.c
@@ -22,7 +22,7 @@ static bool
  tpm_test_swtpm_skip(void)
  {
  if (!tpm_util_swtpm_has_tpm2()) {
-g_test_message("swtpm not in PATH or missing --tpm2 support");
+g_test_skip("swtpm not in PATH or missing --tpm2 support");
  return true;
  }

Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-04-24 Thread Philippe Mathieu-Daudé 
On 4/24/19 11:45 AM, Thomas Huth wrote:
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
> 
> Signed-off-by: Thomas Huth 
> ---
>  tests/tpm-tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
>  tpm_test_swtpm_skip(void)
>  {
>  if (!tpm_util_swtpm_has_tpm2()) {
> -g_test_message("swtpm not in PATH or missing --tpm2 support");
> +g_test_skip("swtpm not in PATH or missing --tpm2 support");
>  return true;
>  }
>  
> 

Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-04-24 Thread Marc-André Lureau 
On Wed, Apr 24, 2019 at 11:49 AM Thomas Huth  wrote:
>
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth 

Reviewed-by: Marc-André Lureau 

> ---
>  tests/tpm-tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
>  tpm_test_swtpm_skip(void)
>  {
>  if (!tpm_util_swtpm_has_tpm2()) {
> -g_test_message("swtpm not in PATH or missing --tpm2 support");
> +g_test_skip("swtpm not in PATH or missing --tpm2 support");
>  return true;
>  }
>
> --
> 2.21.0
>
>


-- 
Marc-André Lureau

[Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests

2019-04-24 Thread Thomas Huth 
Since we do not use gtester anymore (which had a bug here),
we can now use g_test_skip() to mark skipped tests.

Signed-off-by: Thomas Huth 
---
 tests/tpm-tests.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 582ec0cfd4..e640777aa9 100644
--- a/tests/tpm-tests.c
+++ b/tests/tpm-tests.c
@@ -22,7 +22,7 @@ static bool
 tpm_test_swtpm_skip(void)
 {
 if (!tpm_util_swtpm_has_tpm2()) {
-g_test_message("swtpm not in PATH or missing --tpm2 support");
+g_test_skip("swtpm not in PATH or missing --tpm2 support");
 return true;
 }
 
-- 
2.21.0