Re: [Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment

2019-06-23 Thread David Gibson
On Fri, Jun 21, 2019 at 07:01:20PM -0300, Fabiano Rosas wrote:
> This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
> capabilities", which added support to more than one DMA window.
> 
> Signed-off-by: Fabiano Rosas 

Acked-by: David Gibson 

> ---
>  include/hw/vfio/vfio-common.h | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index a88b69b675..9107bd41c0 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -74,11 +74,6 @@ typedef struct VFIOContainer {
>  int error;
>  bool initialized;
>  unsigned long pgsizes;
> -/*
> - * This assumes the host IOMMU can support only a single
> - * contiguous IOVA window.  We may need to generalize that in
> - * future
> - */
>  QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
>  QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
>  QLIST_HEAD(, VFIOGroup) group_list;

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


[Qemu-devel] [PATCH] vfio-common.h: Remove inaccurate comment

2019-06-21 Thread Fabiano Rosas
This is a left-over from "f4ec5e26ed vfio: Add host side DMA window
capabilities", which added support to more than one DMA window.

Signed-off-by: Fabiano Rosas 
---
 include/hw/vfio/vfio-common.h | 5 -
 1 file changed, 5 deletions(-)

diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index a88b69b675..9107bd41c0 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -74,11 +74,6 @@ typedef struct VFIOContainer {
 int error;
 bool initialized;
 unsigned long pgsizes;
-/*
- * This assumes the host IOMMU can support only a single
- * contiguous IOVA window.  We may need to generalize that in
- * future
- */
 QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
 QLIST_HEAD(, VFIOHostDMAWindow) hostwin_list;
 QLIST_HEAD(, VFIOGroup) group_list;
-- 
2.20.1