Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute

[Stefan Hajnoczi]

On Wed, Jan 11, 2012 at 07:47:37PM +0100, Stefan Weil wrote:
> Every function with printf like arguments must have it
> (see file HACKING), so add it.
> 
> Signed-off-by: Stefan Weil 
> ---
>  fsdev/virtfs-proxy-helper.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

[Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute

[Stefan Weil]

Every function with printf like arguments must have it
(see file HACKING), so add it.

Signed-off-by: Stefan Weil 
---
 fsdev/virtfs-proxy-helper.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 21e9b16..4a507d8 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -54,7 +54,7 @@ static struct option helper_opts[] = {
 static bool is_daemon;
 static bool get_version; /* IOC getversion IOCTL supported */
 
-static void do_log(int loglevel, const char *format, ...)
+static void GCC_FMT_ATTR(2, 3) do_log(int loglevel, const char *format, ...)
 {
 va_list ap;
 
-- 
1.7.2.5