Re: [Qemu-devel] [PATCH] virtio-serial-bus: Delete timer from list before free it

2017-03-14 Thread Hailiang Zhang

ping... ?

On 2017/3/8 4:01, Amit Shah wrote:

On (Mon) 06 Mar 2017 [11:29:31], zhanghailiang wrote:

Signed-off-by: zhanghailiang 


Reviewed-by: Amit Shah 

Michael, please pick this up.

Amit






Re: [Qemu-devel] [PATCH] virtio-serial-bus: Delete timer from list before free it

2017-03-07 Thread Amit Shah
On (Mon) 06 Mar 2017 [11:29:31], zhanghailiang wrote:
> Signed-off-by: zhanghailiang 

Reviewed-by: Amit Shah 

Michael, please pick this up.

Amit
-- 
http://log.amitshah.net/



Re: [Qemu-devel] [PATCH] virtio-serial-bus: Delete timer from list before free it

2017-03-06 Thread Paolo Bonzini


On 06/03/2017 04:29, zhanghailiang wrote:
> Signed-off-by: zhanghailiang 
> ---
>  hw/char/virtio-serial-bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index d544cd9..d797a67 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -724,6 +724,7 @@ static void virtio_serial_post_load_timer_cb(void *opaque)
>  }
>  }
>  g_free(s->post_load->connected);
> +timer_del(s->post_load->timer);
>  timer_free(s->post_load->timer);
>  g_free(s->post_load);
>  s->post_load = NULL;
> 

Reviewed-by: Paolo Bonzini 
Cc: qemu-sta...@nongnu.org



[Qemu-devel] [PATCH] virtio-serial-bus: Delete timer from list before free it

2017-03-05 Thread zhanghailiang
Signed-off-by: zhanghailiang 
---
 hw/char/virtio-serial-bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index d544cd9..d797a67 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -724,6 +724,7 @@ static void virtio_serial_post_load_timer_cb(void *opaque)
 }
 }
 g_free(s->post_load->connected);
+timer_del(s->post_load->timer);
 timer_free(s->post_load->timer);
 g_free(s->post_load);
 s->post_load = NULL;
-- 
1.8.3.1