Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order

2014-12-08 Thread Gerd Hoffmann 
On Do, 2014-11-20 at 17:07 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei 
> 
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
>  &fg is passed to bg
>  &bg is passed to fg

Added to vnc queue.

thanks,
  Gerd

Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order

2014-12-08 Thread Gonglei 
On 2014/11/20 17:07, Gonglei (Arei) wrote:

> From: Gonglei 
> 
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
>  &fg is passed to bg
>  &bg is passed to fg
> 
> Cc: Gerd Hoffmann 
> Signed-off-by: Gonglei 
> ---
>  ui/vnc-enc-tight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 3d1b5cd..9a9ddf2 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, 
> int w, int h)
>  }
>  #endif
>  
> -colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
> +colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
>  
>  #ifdef CONFIG_VNC_JPEG
>  if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {

Ping...

Regards,
-Gonglei

Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order

2014-11-25 Thread Stefan Hajnoczi 
On Thu, Nov 20, 2014 at 05:07:06PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei 
> 
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
>  &fg is passed to bg
>  &bg is passed to fg
> 
> Cc: Gerd Hoffmann 
> Signed-off-by: Gonglei 
> ---
>  ui/vnc-enc-tight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


pgp63O3lq5Nww.pgp
Description: PGP signature

[Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order

2014-11-20 Thread arei.gonglei 
From: Gonglei 

Arguments in wrong order (SWAPPED_ARGUMENTS)
The positions of arguments in the call to
tight_fill_palette do not match the ordering of the parameters:
 &fg is passed to bg
 &bg is passed to fg

Cc: Gerd Hoffmann 
Signed-off-by: Gonglei 
---
 ui/vnc-enc-tight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 3d1b5cd..9a9ddf2 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, int 
w, int h)
 }
 #endif
 
-colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
+colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
 
 #ifdef CONFIG_VNC_JPEG
 if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {
-- 
1.7.12.4