Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor
于 2011-10-4 21:55, Luiz Capitulino 写道: On Wed, 28 Sep 2011 10:16:19 +0100 Stefan Hajnoczistefa...@gmail.com wrote: On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xiaxiaw...@linux.vnet.ibm.com wrote: During my test, I found it inconvenient when I type help or help info, because the information was shown without orderliness. This patch would just show the help information in sorted order. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the command list is sorted. Wayne Xia (1): Sort the help info shown in monitor monitor.c | 97 ++-- 1 files changed, 93 insertions(+), 4 deletions(-) This is a nice idea. We could keep hmp/qmp-commands.hx in sorted order but that prevents us from keeping related commands together in those files (and the generated documentation?). So sorting at run-time makes sense. The info help command reads from hmp-commands.hx and the info_cmds array, I would prefer to get those sorted. thanks, sorting info_cmds array seems more reasonable for that related things would be kept here in one place not another queue, would change in next patch. -- Best Regards Wayne Xia mail:xiaw...@linux.vnet.ibm.com tel:86-010-82450803
Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor
On Wed, 28 Sep 2011 10:16:19 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xia xiaw...@linux.vnet.ibm.com wrote: During my test, I found it inconvenient when I type help or help info, because the information was shown without orderliness. This patch would just show the help information in sorted order. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the command list is sorted. Wayne Xia (1): Sort the help info shown in monitor monitor.c | 97 ++-- 1 files changed, 93 insertions(+), 4 deletions(-) This is a nice idea. We could keep hmp/qmp-commands.hx in sorted order but that prevents us from keeping related commands together in those files (and the generated documentation?). So sorting at run-time makes sense. The info help command reads from hmp-commands.hx and the info_cmds array, I would prefer to get those sorted.
[Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor
During my test, I found it inconvenient when I type help or help info, because the information was shown without orderliness. This patch would just show the help information in sorted order. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the command list is sorted. Wayne Xia (1): Sort the help info shown in monitor monitor.c | 97 ++-- 1 files changed, 93 insertions(+), 4 deletions(-) -- 1.7.6
Re: [Qemu-devel] [PATCH 0/1] Make the help info more friendly in monitor
On Wed, Sep 28, 2011 at 10:00 AM, Wayne Xia xiaw...@linux.vnet.ibm.com wrote: During my test, I found it inconvenient when I type help or help info, because the information was shown without orderliness. This patch would just show the help information in sorted order. For eg: (qemu)help acl_add acl_policy acl_remove acl_reset acl_show balloon block_passwd ... the command list is sorted. Wayne Xia (1): Sort the help info shown in monitor monitor.c | 97 ++-- 1 files changed, 93 insertions(+), 4 deletions(-) This is a nice idea. We could keep hmp/qmp-commands.hx in sorted order but that prevents us from keeping related commands together in those files (and the generated documentation?). So sorting at run-time makes sense. Stefan
