Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)
Greg Kurz writes: > On Mon, 18 Jan 2016 17:39:28 +0100 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > Hi, >> > >> > This series moves all the 9pfs/fsdev code to use error_report(), with the >> > notable exception of virtfs-proxy-helper, which doesn't need it. >> > >> > Markus, >> > >> > Should this patches go through your tree ? Or can they go through my 9p >> > tree >> > if you ack them ? >> >> It can certainly go through your tree! >> >> My tree is meant for crosscutting error work. I also offer it >> maintainers who prefer to leave the pull request to me. >> >> PATCH 1 could use a bit of polish, and I encourage you to respin. But >> it's not wrong, therefore >> >> Series >> Reviewed-by: Markus Armbruster >> > > Thanks Markus ! > > I've respun the series with your suggestions. Is it expected I repost to > qemu-devel before doing a pull request ? Maintainers sometimes skip posting trivially revised patches for additional review before doing a pull request. Posting them is never wrong, though. When in doubt, post :)
Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)
On Mon, 18 Jan 2016 17:39:28 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > Hi, > > > > This series moves all the 9pfs/fsdev code to use error_report(), with the > > notable exception of virtfs-proxy-helper, which doesn't need it. > > > > Markus, > > > > Should this patches go through your tree ? Or can they go through my 9p tree > > if you ack them ? > > It can certainly go through your tree! > > My tree is meant for crosscutting error work. I also offer it > maintainers who prefer to leave the pull request to me. > > PATCH 1 could use a bit of polish, and I encourage you to respin. But > it's not wrong, therefore > > Series > Reviewed-by: Markus Armbruster > Thanks Markus ! I've respun the series with your suggestions. Is it expected I repost to qemu-devel before doing a pull request ? Cheers. -- Greg
Re: [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)
Greg Kurz writes: > Hi, > > This series moves all the 9pfs/fsdev code to use error_report(), with the > notable exception of virtfs-proxy-helper, which doesn't need it. > > Markus, > > Should this patches go through your tree ? Or can they go through my 9p tree > if you ack them ? It can certainly go through your tree! My tree is meant for crosscutting error work. I also offer it maintainers who prefer to leave the pull request to me. PATCH 1 could use a bit of polish, and I encourage you to respin. But it's not wrong, therefore Series Reviewed-by: Markus Armbruster
[Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)
Hi, This series moves all the 9pfs/fsdev code to use error_report(), with the notable exception of virtfs-proxy-helper, which doesn't need it. Markus, Should this patches go through your tree ? Or can they go through my 9p tree if you ack them ? Cheers. -- Greg --- Greg Kurz (2): 9pfs: use error_report() instead of fprintf(stderr) fsdev: use error_report() instead of fprintf(stderr) fsdev/qemu-fsdev.c |7 --- hw/9pfs/9p-handle.c |5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c|2 +- 5 files changed, 22 insertions(+), 19 deletions(-)
