Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
Il 16/01/2013 21:19, Kevin Wolf ha scritto: > Paolo, especially the first one is worrying with respect to the test status of > this code. We should probably give it some additional testing. > > Kevin Wolf (2): > win32-aio: Fix vectored reads > win32-aio: Fix memory leak > > block/win32-aio.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Yes, the worrying part is especially that IIUC qtest does not support Windows. There's no way to get good coverage without qtest. Paolo
Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
Il 17/01/2013 12:35, Kevin Wolf ha scritto: > Am 17.01.2013 11:53, schrieb Paolo Bonzini: >> Il 16/01/2013 21:19, Kevin Wolf ha scritto: >>> Paolo, especially the first one is worrying with respect to the test status >>> of >>> this code. We should probably give it some additional testing. >>> >>> Kevin Wolf (2): >>> win32-aio: Fix vectored reads >>> win32-aio: Fix memory leak >>> >>> block/win32-aio.c |4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >> >> Yes, the worrying part is especially that IIUC qtest does not support >> Windows. There's no way to get good coverage without qtest. > > Why that? If block drivers aren't testable from qemu-iotests with only > qemu-img and qemu-io, then there's something we did wrong. This specific > code would have been easily covered with qemu-io -k -n -c 'readv ...' > (which is how I found the bug and tested the fix). Doh, that was really stupid. /me unsuccessfully tries to blame flu > Hm, or actually, is cache=none even needed for aio=native on Windows? In > any case I think some documentation needs to be updated. Honestly I have no idea. However, I don't think so. Paolo > qemu-iotests under Wine may need some polishing, though, and of course > needs someone to run it regularly with the right parameters. (In fact, > it seems we don't even run the tests with Linux AIO)
Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
Am 17.01.2013 11:53, schrieb Paolo Bonzini: > Il 16/01/2013 21:19, Kevin Wolf ha scritto: >> Paolo, especially the first one is worrying with respect to the test status >> of >> this code. We should probably give it some additional testing. >> >> Kevin Wolf (2): >> win32-aio: Fix vectored reads >> win32-aio: Fix memory leak >> >> block/win32-aio.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> > > Yes, the worrying part is especially that IIUC qtest does not support > Windows. There's no way to get good coverage without qtest. Why that? If block drivers aren't testable from qemu-iotests with only qemu-img and qemu-io, then there's something we did wrong. This specific code would have been easily covered with qemu-io -k -n -c 'readv ...' (which is how I found the bug and tested the fix). Hm, or actually, is cache=none even needed for aio=native on Windows? In any case I think some documentation needs to be updated. qemu-iotests under Wine may need some polishing, though, and of course needs someone to run it regularly with the right parameters. (In fact, it seems we don't even run the tests with Linux AIO) Kevin
Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
On Wed, Jan 16, 2013 at 09:19:58PM +0100, Kevin Wolf wrote: > Paolo, especially the first one is worrying with respect to the test status of > this code. We should probably give it some additional testing. > > Kevin Wolf (2): > win32-aio: Fix vectored reads > win32-aio: Fix memory leak > > block/win32-aio.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > -- > 1.7.6.5 > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
[Qemu-devel] [PATCH 0/2] win32-aio fixes
Paolo, especially the first one is worrying with respect to the test status of this code. We should probably give it some additional testing. Kevin Wolf (2): win32-aio: Fix vectored reads win32-aio: Fix memory leak block/win32-aio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.6.5
[Qemu-devel] [PATCH 0/2] win32-aio fixes
Paolo, especially the first one is worrying with respect to the test status of this code. We should probably give it some additional testing. Kevin Wolf (2): win32-aio: Fix vectored reads win32-aio: Fix memory leak block/win32-aio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.6.5
