Re: [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's

2017-03-21 Thread Dr. David Alan Gilbert 
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)"  writes:
> 
> > From: "Dr. David Alan Gilbert" 
> >
> > I found myself trying to understand cur_mon and found a bunch
> > of uses that could easily be replaced by error_report or Error **.
> 
> Speaking of cur_mon: a patch making it thread-local would be most
> welcome.

Yep, that's what I was thinking about while I was just working out where
it's used.

> Some of error wavcapture messages still aren't so great, but it's an
> obvious improvement, so
> Reviewed-by: Markus Armbruster 

Thanks.

Dave
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's

2017-03-21 Thread Markus Armbruster 
"Dr. David Alan Gilbert (git)"  writes:

> From: "Dr. David Alan Gilbert" 
>
> I found myself trying to understand cur_mon and found a bunch
> of uses that could easily be replaced by error_report or Error **.

Speaking of cur_mon: a patch making it thread-local would be most
welcome.

Some of error wavcapture messages still aren't so great, but it's an
obvious improvement, so
Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's

2017-03-20 Thread Dr. David Alan Gilbert (git) 
From: "Dr. David Alan Gilbert" 

I found myself trying to understand cur_mon and found a bunch
of uses that could easily be replaced by error_report or Error **.

Dave

Dr. David Alan Gilbert (2):
  save_vmstate: Convert to Error** from Monitor *
  wavcapture: Convert to error_report

 audio/wavcapture.c   | 39 +--
 include/sysemu/sysemu.h  |  2 +-
 migration/savevm.c   | 31 ++-
 replay/replay-snapshot.c |  6 --
 4 files changed, 40 insertions(+), 38 deletions(-)

-- 
2.9.3