Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter
On Thu, Sep 08, 2016 at 09:14:10AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote: > > Add a parameter to associate an iSCSI block driver instance with an -iscsi > > object. This is more powerful than relying on the implicit target IQN > > naming > > convention since that only allows one -iscsi object per target. > > I'm inclined to say we should *not* do this, as it just serves to perpetuate > usage of the insane -iscsi arg. Instead we could focus on fixing the iSCSI > blockdev for 2.8 so that it directly supports properties for everything that > you can set via -iscsi and deprecate -iscsi entirely. We've got enough time > during 2.8 to get this entirely converted I think. That's fine. There's not much advantage to defining -iscsi objects except that a single -iscsi can be used by multiple iscsi drives. Stefan signature.asc Description: PGP signature
Re: [Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter
On Wed, Sep 07, 2016 at 05:23:09PM -0400, Stefan Hajnoczi wrote: > Add a parameter to associate an iSCSI block driver instance with an -iscsi > object. This is more powerful than relying on the implicit target IQN naming > convention since that only allows one -iscsi object per target. I'm inclined to say we should *not* do this, as it just serves to perpetuate usage of the insane -iscsi arg. Instead we could focus on fixing the iSCSI blockdev for 2.8 so that it directly supports properties for everything that you can set via -iscsi and deprecate -iscsi entirely. We've got enough time during 2.8 to get this entirely converted I think. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
[Qemu-devel] [PATCH 0/3] iscsi: add -drive ..., iscsi= parameter
Add a parameter to associate an iSCSI block driver instance with an -iscsi object. This is more powerful than relying on the implicit target IQN naming convention since that only allows one -iscsi object per target. Stefan Hajnoczi (3): iscsi: extract find_iscsi_opts() helper function iscsi: simplify -iscsi QemuOpts fetching iscsi: add iscsi= option block/iscsi.c | 113 +++- qemu-options.hx | 8 +++- 2 files changed, 52 insertions(+), 69 deletions(-) -- 2.7.4
