Re: [Qemu-devel] [PATCH 0/3] net: drop implicit peer from offload API

[Vincenzo Maffione]

Hello,
  It looks ok to me.

Cheers
  Vincenzo


2014-02-20 12:14 GMT+01:00 Stefan Hajnoczi :

> This series is based on my net tree, which already has Vincenzo's "Add
> netmap
> backend offloadings support" patch series merged.
>
> After merging the series I realized we were bypassing the net.h API and
> directly accessing nc->info->... in some cases.  This series cleans that
> up, at
> the cost of moving ->peer back up to offload API callers.
>
> I think that's the right thing to do to make net.h APIs consistent (the
> other
> functions don't have implicit ->peer) and avoid bypassing the API.
>
> Stefan Hajnoczi (3):
>   net: remove implicit peer from offload API
>   vhost_net: use offload API instead of bypassing it
>   virtio-net: use qemu_get_queue() where possible
>
>  hw/net/vhost_net.c  |  6 +++---
>  hw/net/virtio-net.c | 12 ++--
>  hw/net/vmxnet3.c| 18 +-
>  include/net/net.h   | 14 +++---
>  net/net.c   | 36 ++--
>  5 files changed, 43 insertions(+), 43 deletions(-)
>
> --
> 1.8.5.3
>
>


-- 
Vincenzo Maffione

[Qemu-devel] [PATCH 0/3] net: drop implicit peer from offload API

[Stefan Hajnoczi]

This series is based on my net tree, which already has Vincenzo's "Add netmap
backend offloadings support" patch series merged.

After merging the series I realized we were bypassing the net.h API and
directly accessing nc->info->... in some cases.  This series cleans that up, at
the cost of moving ->peer back up to offload API callers.

I think that's the right thing to do to make net.h APIs consistent (the other
functions don't have implicit ->peer) and avoid bypassing the API.

Stefan Hajnoczi (3):
  net: remove implicit peer from offload API
  vhost_net: use offload API instead of bypassing it
  virtio-net: use qemu_get_queue() where possible

 hw/net/vhost_net.c  |  6 +++---
 hw/net/virtio-net.c | 12 ++--
 hw/net/vmxnet3.c| 18 +-
 include/net/net.h   | 14 +++---
 net/net.c   | 36 ++--
 5 files changed, 43 insertions(+), 43 deletions(-)

-- 
1.8.5.3