Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks

2014-11-11 Thread Paolo Bonzini 


On 07/11/2014 17:04, Andrew Jones wrote:
 See individual patches.
 
 Andrew Jones (3):
   vl: fix max_cpus check
   vl: sanity check cpu topology
   vl: warn on topology - maxcpus mismatch
 
  vl.c | 38 --
  1 file changed, 32 insertions(+), 6 deletions(-)
 

Looks good, but Eduardo should be the authority on this stuff.

Adding Peter Lieven too, because he looked at bad -smp configurations
too in the past.

Paolo

Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks

2014-11-11 Thread Eduardo Habkost 
On Tue, Nov 11, 2014 at 12:15:26PM +0100, Paolo Bonzini wrote:
 
 
 On 07/11/2014 17:04, Andrew Jones wrote:
  See individual patches.
  
  Andrew Jones (3):
vl: fix max_cpus check
vl: sanity check cpu topology
vl: warn on topology - maxcpus mismatch
  
   vl.c | 38 --
   1 file changed, 32 insertions(+), 6 deletions(-)
  
 
 Looks good, but Eduardo should be the authority on this stuff.

Patch 1/3 is an obvious fix that should go to 2.2.

Patch 2/3 is fixing two diferent bugs. One fix is making QEMU abort when
I think it really should, but the second fix may cause a silent ABI
change.

Patch 3/3 is just an warning, but it is changing the meaning of the
sockets option (from sockets with online CPUs to all available
sockets (even the empty ones)), so I think it makes sense only after we
actually change its meaning in 2.3.

-- 
Eduardo

[Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks

2014-11-07 Thread Andrew Jones 
See individual patches.

Andrew Jones (3):
  vl: fix max_cpus check
  vl: sanity check cpu topology
  vl: warn on topology - maxcpus mismatch

 vl.c | 38 --
 1 file changed, 32 insertions(+), 6 deletions(-)

-- 
1.9.3