[Qemu-devel] [PATCH 0/4] Fix virtio memleaks
The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler fixes that as well. This patchset is on top of the two balloon series I've sent out yesterday and today. Amit Shah (4): virtio-balloon: Add exit handler, fix memleaks virtio-blk: Fix memleak on exit virtio-net: Fix potential use-after-free virtio: Plug memleak by freeing vdev hw/virtio-balloon.c |9 + hw/virtio-blk.c |1 + hw/virtio-net.c |2 +- hw/virtio-pci.c | 11 ++- hw/virtio.c |1 + hw/virtio.h |1 + 6 files changed, 23 insertions(+), 2 deletions(-) -- 1.7.6
Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks
On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote: The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler fixes that as well. This patchset is on top of the two balloon series I've sent out yesterday and today. This looks good to me. What do you say I put patches 2-4 on my tree, and you put patch 1 on yours? Amit Shah (4): virtio-balloon: Add exit handler, fix memleaks virtio-blk: Fix memleak on exit virtio-net: Fix potential use-after-free virtio: Plug memleak by freeing vdev hw/virtio-balloon.c |9 + hw/virtio-blk.c |1 + hw/virtio-net.c |2 +- hw/virtio-pci.c | 11 ++- hw/virtio.c |1 + hw/virtio.h |1 + 6 files changed, 23 insertions(+), 2 deletions(-) -- 1.7.6
Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks
On (Wed) 27 Jul 2011 [12:08:52], Michael S. Tsirkin wrote: On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote: The memory allocated in virtio_common_init() wasn't being freed anywhere. Fix that. The balloon handler wasn't unregistering its savevm section, adding an exit handler fixes that as well. This patchset is on top of the two balloon series I've sent out yesterday and today. This looks good to me. What do you say I put patches 2-4 on my tree, and you put patch 1 on yours? Sure. Amit