Re: [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side
Am 07.06.2017 um 19:53 hat Juan Quintela geschrieben: > Juan Quintelawrote: > > Hi > > Hi Kevin and Stefan, I intended to cc you on this series. > > Is this what you were asking for block layer migration? > > Do you need anything else? I didn't manage to apply this to my local git tree, so my review is based on scanning the emails. The important part for us is probably where you call the .cleanup_load callback. As I commented on the patch, I don't see any place in this series that calls it. We need it before bdrv_invalidate_cache_all() is called, I think. Kevin
Re: [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side
Juan Quintelawrote: > Hi Hi Kevin and Stefan, I intended to cc you on this series. Is this what you were asking for block layer migration? Do you need anything else? Thanks, Juan. > This series make: > - use of cleanup/save methods generic, not only for save_live methods > - create the equivalent methods for the load side (load_setup/cleanup) > - Make ram use this methods to see how/when they are used. > > Stefan, Kevin, this were the methods that you asked for the block.c > migration, right? Please, comment if they are enough for you. > > This are on top of the ramstate_dynamic series that I just posted. > > Please, review. > > Later, Juan. > > Juan Quintela (5): > migration: Rename save_live_setup() to save_setup() > migration: Rename cleanup() to save_cleanup() > migration: Create load_setup()/cleanup() methods > migration: Convert ram to use new load_setup()/load_cleanup() > migration: Make compression_threads use save/load_setup/cleanup() > > hw/ppc/spapr.c | 4 +-- > include/migration/register.h | 6 ++-- > migration/block.c| 4 +-- > migration/migration.c| 8 -- > migration/ram.c | 66 > ++-- > migration/ram.h | 6 > migration/savevm.c | 41 +++ > 7 files changed, 89 insertions(+), 46 deletions(-)
[Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side
Hi This series make: - use of cleanup/save methods generic, not only for save_live methods - create the equivalent methods for the load side (load_setup/cleanup) - Make ram use this methods to see how/when they are used. Stefan, Kevin, this were the methods that you asked for the block.c migration, right? Please, comment if they are enough for you. This are on top of the ramstate_dynamic series that I just posted. Please, review. Later, Juan. Juan Quintela (5): migration: Rename save_live_setup() to save_setup() migration: Rename cleanup() to save_cleanup() migration: Create load_setup()/cleanup() methods migration: Convert ram to use new load_setup()/load_cleanup() migration: Make compression_threads use save/load_setup/cleanup() hw/ppc/spapr.c | 4 +-- include/migration/register.h | 6 ++-- migration/block.c| 4 +-- migration/migration.c| 8 -- migration/ram.c | 66 ++-- migration/ram.h | 6 migration/savevm.c | 41 +++ 7 files changed, 89 insertions(+), 46 deletions(-) -- 2.9.4