Re: [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec()

[Richard Henderson]

On 05/11/2016 12:21 AM, Sergey Fedorov wrote:

From: Sergey Fedorov 

cpu_exec() was a huge function also sprinkled with some preprocessor
directives. It was hard to read and see the main loop crowded by all
this code. Restructure cpu_exec() by moving its conceptual parts into
separate static inline functions. That makes it possible to see the
whole main loop at once, especially its sigsetjmp() handling part.

This series is based on commit
40f646483a11 (cpu-exec: Remove relic orphaned comment)
from
git://github.com/rth7680/qemu.git tcg-next
and is available at
git://github.com/sergefdrv/qemu.git cpu_exec-restructure-v2

Summary of changes in v2:
 * Declare x86_cpu variable in the inner-most block [PATCH 1/5]

Sergey Fedorov (5):
  cpu-exec: Move halt handling out of cpu_exec()
  cpu-exec: Move exception handling out of cpu_exec()
  cpu-exec: Move interrupt handling out of cpu_exec()
  cpu-exec: Move TB execution stuff out of cpu_exec()
  cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec()

 cpu-exec.c | 395 +
 1 file changed, 211 insertions(+), 184 deletions(-)



Applied to tcg-next.


r~

[Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec()

[Sergey Fedorov]

From: Sergey Fedorov 

cpu_exec() was a huge function also sprinkled with some preprocessor
directives. It was hard to read and see the main loop crowded by all
this code. Restructure cpu_exec() by moving its conceptual parts into
separate static inline functions. That makes it possible to see the
whole main loop at once, especially its sigsetjmp() handling part.

This series is based on commit
40f646483a11 (cpu-exec: Remove relic orphaned comment)
from
git://github.com/rth7680/qemu.git tcg-next
and is available at
git://github.com/sergefdrv/qemu.git cpu_exec-restructure-v2

Summary of changes in v2:
 * Declare x86_cpu variable in the inner-most block [PATCH 1/5]

Sergey Fedorov (5):
  cpu-exec: Move halt handling out of cpu_exec()
  cpu-exec: Move exception handling out of cpu_exec()
  cpu-exec: Move interrupt handling out of cpu_exec()
  cpu-exec: Move TB execution stuff out of cpu_exec()
  cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec()

 cpu-exec.c | 395 +
 1 file changed, 211 insertions(+), 184 deletions(-)

-- 
1.9.1

Re: [Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec()

[Sergey Fedorov]

On 10/05/16 18:46, Sergey Fedorov wrote:
> From: Sergey Fedorov 
>
> cpu_exec() was a huge function also sprinkled with some preprocessor
> directives. It was hard to read and see the main loop crowded by all
> this code. Restructure cpu_exec() by moving its conceptual parts into
> separate static inline functions. That makes it possible to see the
> whole main loop at once, especially its sigsetjmp() handling part.
>
> This series is based on commit
> 40f646483a11 (cpu-exec: Remove relic orphaned comment)
> from
> git://github.com/rth7680/qemu.git tcg-next
> and is available at
> git://github.com/sergefdrv/qemu.git cpu_exec-restructure
>
> Sergey Fedorov (5):
>   cpu-exec: Move halt handling out of cpu_exec()
>   cpu-exec: Move exception handling out of cpu_exec()
>   cpu-exec: Move interrupt handling out of cpu_exec()
>   cpu-exec: Move TB execution stuff out of cpu_exec()
>   cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec()
>
>  cpu-exec.c | 395 
> +
>  1 file changed, 211 insertions(+), 184 deletions(-)
>

Sorry, +CC.

Regards,
Sergey

[Qemu-devel] [PATCH 0/5] cpu-exec: Restructure cpu_exec()

[Sergey Fedorov]

From: Sergey Fedorov 

cpu_exec() was a huge function also sprinkled with some preprocessor
directives. It was hard to read and see the main loop crowded by all
this code. Restructure cpu_exec() by moving its conceptual parts into
separate static inline functions. That makes it possible to see the
whole main loop at once, especially its sigsetjmp() handling part.

This series is based on commit
40f646483a11 (cpu-exec: Remove relic orphaned comment)
from
git://github.com/rth7680/qemu.git tcg-next
and is available at
git://github.com/sergefdrv/qemu.git cpu_exec-restructure

Sergey Fedorov (5):
  cpu-exec: Move halt handling out of cpu_exec()
  cpu-exec: Move exception handling out of cpu_exec()
  cpu-exec: Move interrupt handling out of cpu_exec()
  cpu-exec: Move TB execution stuff out of cpu_exec()
  cpu-exec: Remove unused 'x86_cpu' and 'env' from cpu_exec()

 cpu-exec.c | 395 +
 1 file changed, 211 insertions(+), 184 deletions(-)

-- 
1.9.1