Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code
On Mon, Apr 23, 2012 at 20:39, Stefan Weil s...@weilnetz.de wrote: Am 23.04.2012 22:13, schrieb Anthony Liguori: On 04/20/2012 05:03 AM, Stefan Weil wrote: These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks [PATCH 5/5] qemu-timer: Optimize data structures If you're goign to rev a patch, please resubmit the full series. Otherwise it's a pain in the ass to apply because the patches have to be reordered by hand. It's not so bad if it's the last patch in a series but when it's in the middle, it sucks. Regards, Anthony Liguori The patches 4 and 5 don't depend on each other, so they can be reordered. Then patch 4 (v2) would be the last patch. To avoid further pain, it's now possible to pull this series. Thanks, pulled. Regards, Stefan Weil The following changes since commit 092dfc7714ad7983aeb0cada5d5983e9fde8d84c: Merge remote-tracking branch 'origin/master' into staging (2012-04-23 15:02:53 -0500) are available in the git repository at: git://qemu.weilnetz.de/qemu.git timer for you to fetch changes up to 475d53efedeaf3444e78088939afd376e8843d09: qemu-timer: Optimize data structures (2012-04-23 22:37:12 +0200) Stefan Weil (5): qemu-timer: Remove redundant include statements qemu-timer: Remove unused function qemu_alarm_pending qemu-timer: Use bool, false, true for boolean values qemu-timer: Remove function alarm_has_dynticks qemu-timer: Optimize data structures qemu-timer.c | 94 ++--- qemu-timer.h | 13 ++-- 2 files changed, 33 insertions(+), 74 deletions(-)
Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code
On 04/20/2012 05:03 AM, Stefan Weil wrote: These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks [PATCH 5/5] qemu-timer: Optimize data structures If you're goign to rev a patch, please resubmit the full series. Otherwise it's a pain in the ass to apply because the patches have to be reordered by hand. It's not so bad if it's the last patch in a series but when it's in the middle, it sucks. Regards, Anthony Liguori
Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code
Am 23.04.2012 22:13, schrieb Anthony Liguori: On 04/20/2012 05:03 AM, Stefan Weil wrote: These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks [PATCH 5/5] qemu-timer: Optimize data structures If you're goign to rev a patch, please resubmit the full series. Otherwise it's a pain in the ass to apply because the patches have to be reordered by hand. It's not so bad if it's the last patch in a series but when it's in the middle, it sucks. Regards, Anthony Liguori The patches 4 and 5 don't depend on each other, so they can be reordered. Then patch 4 (v2) would be the last patch. To avoid further pain, it's now possible to pull this series. Regards, Stefan Weil The following changes since commit 092dfc7714ad7983aeb0cada5d5983e9fde8d84c: Merge remote-tracking branch 'origin/master' into staging (2012-04-23 15:02:53 -0500) are available in the git repository at: git://qemu.weilnetz.de/qemu.git timer for you to fetch changes up to 475d53efedeaf3444e78088939afd376e8843d09: qemu-timer: Optimize data structures (2012-04-23 22:37:12 +0200) Stefan Weil (5): qemu-timer: Remove redundant include statements qemu-timer: Remove unused function qemu_alarm_pending qemu-timer: Use bool, false, true for boolean values qemu-timer: Remove function alarm_has_dynticks qemu-timer: Optimize data structures qemu-timer.c | 94 ++--- qemu-timer.h | 13 ++-- 2 files changed, 33 insertions(+), 74 deletions(-)
[Qemu-devel] [PATCH 0/5] qemu-timer: Clean code
These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks [PATCH 5/5] qemu-timer: Optimize data structures
Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code
Il 20/04/2012 12:03, Stefan Weil ha scritto: These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks [PATCH 5/5] qemu-timer: Optimize data structures v2 Reviewed-by: Paolo Bonzini pbonz...@redhat.com Thanks! Paolo
