Re: [Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)
On 12 May 2015 at 00:45, Programmingkid programmingk...@gmail.com wrote: On May 10, 2015, at 6:19 PM, Peter Maydell wrote: I've chosen to implement some of them by simply dropping the backward-compatibility support for OSX 10.4. This is basically a pragmatic decision since I don't think we can support ancient versions forever, especially when I don't actually have a system to test compiling them on. (Last time I tried building QEMU on 10.4 it was an insane pain because you had to start by building all the dependencies and a new compiler too.) I would not be terribly surprised somebody told me we'd already accidentally broken 10.4 compilation, in fact. 10.5 is the last PPC OSX release so it seems like a reasonable minimum-version requirement (though I don't have a 10.5 setup either, so am reliant on people telling me if it breaks.) I hate seeing support for older operating system end. The only thing you appear to be seeing are warnings. Are they really so bad? It might be simpler to just disable warnings. In the end I guess there isn't someone out there who is using QEMU on Mac OS 10.4 or earlier. Well, we've already in some sense dropped 10.4 support, because 10.4 doesn't have rez/setfile, so it won't build with the icon patch applied. I wouldn't mind continuing to support 10.4 if we had at least one person who had 10.4 and had an actual use for 10.4 support and regularly built on 10.4 and told us if we broke things. But we don't, so all that we're really doing with these ifdefs is making our code more complicated and harder to maintain. 10.5 came out in 2007... -- PMM
Re: [Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)
On May 10, 2015, at 6:19 PM, Peter Maydell wrote: This patchset fixes a number of new compile warnings when building on OSX10.10 which were not present on 10.9, which are mostly fixes to avoid deprecated APIs. I've chosen to implement some of them by simply dropping the backward-compatibility support for OSX 10.4. This is basically a pragmatic decision since I don't think we can support ancient versions forever, especially when I don't actually have a system to test compiling them on. (Last time I tried building QEMU on 10.4 it was an insane pain because you had to start by building all the dependencies and a new compiler too.) I would not be terribly surprised somebody told me we'd already accidentally broken 10.4 compilation, in fact. 10.5 is the last PPC OSX release so it seems like a reasonable minimum-version requirement (though I don't have a 10.5 setup either, so am reliant on people telling me if it breaks.) This patchset sits on top of my current cocoa.next branch which you can find here: https://git.linaro.org/people/peter.maydell/qemu-arm.git cocoa.next If you have a pre-10.10 system and can test that this patchset doesn't break compilation that would be nice. (I checked the Apple documentation's notes about when functions and constants were first defined, so it should be OK...) Peter Maydell (6): ui/cocoa: Drop tests for CGImageCreateWithImageInRect support ui/cocoa: Remove compatibility ifdefs for OSX 10.4 ui/cocoa: openPanelDidEnd returnCode should be NSInteger, not int ui/cocoa: Declare that QemuCocoaAppController implements NSApplicationDelegate ui/cocoa: Don't use NSWindow useOptimizedDrawing on OSX 10.10 and up ui/cocoa: Avoid deprecated NSOKButton/NSCancelButton constants ui/cocoa.m | 87 ++ 1 file changed, 37 insertions(+), 50 deletions(-) -- 2.2.1 I hate seeing support for older operating system end. The only thing you appear to be seeing are warnings. Are they really so bad? It might be simpler to just disable warnings. In the end I guess there isn't someone out there who is using QEMU on Mac OS 10.4 or earlier.
[Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)
This patchset fixes a number of new compile warnings when building on OSX10.10 which were not present on 10.9, which are mostly fixes to avoid deprecated APIs. I've chosen to implement some of them by simply dropping the backward-compatibility support for OSX 10.4. This is basically a pragmatic decision since I don't think we can support ancient versions forever, especially when I don't actually have a system to test compiling them on. (Last time I tried building QEMU on 10.4 it was an insane pain because you had to start by building all the dependencies and a new compiler too.) I would not be terribly surprised somebody told me we'd already accidentally broken 10.4 compilation, in fact. 10.5 is the last PPC OSX release so it seems like a reasonable minimum-version requirement (though I don't have a 10.5 setup either, so am reliant on people telling me if it breaks.) This patchset sits on top of my current cocoa.next branch which you can find here: https://git.linaro.org/people/peter.maydell/qemu-arm.git cocoa.next If you have a pre-10.10 system and can test that this patchset doesn't break compilation that would be nice. (I checked the Apple documentation's notes about when functions and constants were first defined, so it should be OK...) Peter Maydell (6): ui/cocoa: Drop tests for CGImageCreateWithImageInRect support ui/cocoa: Remove compatibility ifdefs for OSX 10.4 ui/cocoa: openPanelDidEnd returnCode should be NSInteger, not int ui/cocoa: Declare that QemuCocoaAppController implements NSApplicationDelegate ui/cocoa: Don't use NSWindow useOptimizedDrawing on OSX 10.10 and up ui/cocoa: Avoid deprecated NSOKButton/NSCancelButton constants ui/cocoa.m | 87 ++ 1 file changed, 37 insertions(+), 50 deletions(-) -- 2.2.1
