Re: [Qemu-devel] [PATCH 00/12] vl: graphics stubs + #ifdef cleanup, eliminate some global vars

2015-11-12 Thread Paolo Bonzini


On 11/11/2015 20:09, Eduardo Habkost wrote:
> * Clean up the graphics initialization code to reduce the
>   number of #ifdefs;
> * Remove the display_type == DT_NOGRAPHIC checks from hardware
>   emulation code;
> * Make the display_type global variable a local variable on
>   main();
> * Make the display_remote static variable a local variable on
>   main().
> 
> Eduardo Habkost (12):
>   vl: Add DT_COCOA DisplayType value
>   stubs: Add VNC initialization stubs
>   stubs: curses_display_init() stub
>   stubs: SDL initialization stubs
>   stubs: cocoa_display_init() stub
>   stubs: gtk_display_init() stub
>   stubs: spice initialization stubs
>   milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create()
>   vl: Replace DT_NOGRAPHIC with MachineState field
>   vl: Make display_type a local variable
>   vl: Move DisplayType typedef to vl.c
>   vl: Make display_remote a local variable
> 
>  hw/lm32/milkymist-hw.h  |  4 
>  hw/lm32/milkymist.c |  4 +++-
>  hw/nvram/fw_cfg.c   |  6 +++--
>  hw/sparc/sun4m.c|  2 +-
>  include/hw/boards.h |  1 +
>  include/sysemu/sysemu.h | 11 -
>  include/ui/console.h|  4 ++--
>  stubs/Makefile.objs |  5 
>  stubs/cocoa.c   | 10 
>  stubs/curses.c  | 10 
>  stubs/gtk.c | 10 
>  stubs/sdl.c | 17 +
>  stubs/spice.c   | 13 ++
>  stubs/vnc.c | 22 +
>  vl.c| 63 
> +++--
>  15 files changed, 122 insertions(+), 60 deletions(-)
>  create mode 100644 stubs/cocoa.c
>  create mode 100644 stubs/curses.c
>  create mode 100644 stubs/gtk.c
>  create mode 100644 stubs/sdl.c
>  create mode 100644 stubs/spice.c
>  create mode 100644 stubs/vnc.c

Interesting.  This wasn't how stubs were meant to be used, but I cannot
formulate any objection that makes sense. :)

However, please move the new files to stubs/ui/.

I'll review the DT_NOGRAPHIC changes shortly.

Paolo



[Qemu-devel] [PATCH 00/12] vl: graphics stubs + #ifdef cleanup, eliminate some global vars

2015-11-11 Thread Eduardo Habkost
* Clean up the graphics initialization code to reduce the
  number of #ifdefs;
* Remove the display_type == DT_NOGRAPHIC checks from hardware
  emulation code;
* Make the display_type global variable a local variable on
  main();
* Make the display_remote static variable a local variable on
  main().

Eduardo Habkost (12):
  vl: Add DT_COCOA DisplayType value
  stubs: Add VNC initialization stubs
  stubs: curses_display_init() stub
  stubs: SDL initialization stubs
  stubs: cocoa_display_init() stub
  stubs: gtk_display_init() stub
  stubs: spice initialization stubs
  milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create()
  vl: Replace DT_NOGRAPHIC with MachineState field
  vl: Make display_type a local variable
  vl: Move DisplayType typedef to vl.c
  vl: Make display_remote a local variable

 hw/lm32/milkymist-hw.h  |  4 
 hw/lm32/milkymist.c |  4 +++-
 hw/nvram/fw_cfg.c   |  6 +++--
 hw/sparc/sun4m.c|  2 +-
 include/hw/boards.h |  1 +
 include/sysemu/sysemu.h | 11 -
 include/ui/console.h|  4 ++--
 stubs/Makefile.objs |  5 
 stubs/cocoa.c   | 10 
 stubs/curses.c  | 10 
 stubs/gtk.c | 10 
 stubs/sdl.c | 17 +
 stubs/spice.c   | 13 ++
 stubs/vnc.c | 22 +
 vl.c| 63 +++--
 15 files changed, 122 insertions(+), 60 deletions(-)
 create mode 100644 stubs/cocoa.c
 create mode 100644 stubs/curses.c
 create mode 100644 stubs/gtk.c
 create mode 100644 stubs/sdl.c
 create mode 100644 stubs/spice.c
 create mode 100644 stubs/vnc.c

-- 
2.1.0