Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On Fri, Apr 20, 2012 at 12:45, Alexander Graf ag...@suse.de wrote: On 16.04.2012, at 21:46, Blue Swirl wrote: On Mon, Apr 16, 2012 at 19:28, Peter Maydell peter.mayd...@linaro.org wrote: On 16 April 2012 20:12, Blue Swirl blauwir...@gmail.com wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. I use stgit a lot and I haven't run into this issue yet... Couple of approaches that spring to mind: 1. use stg rebase ppc-next to put your patch stack on top of ppc-next (This is how I did the recent cp15-rework series which sits on top of the drop-cpu_reset_model_id patchset, for instance.) 2. create a new branch starting from ppc-next and stg pick the relevant patches into it. (I use that for sending subsets of omap related patches from qemu-linaro.) Thanks, cool. I'll try that. I'm considering dropping stgit (it has emptied too many patches) and use plain git, this way I could start using branches. So how are things going there? Apparently all the patches from ppc-next should be in mainline, Andreas is happy with the state of QOM on PPC as it is by now too, so it's a perfect point in time to do this change! I'll try to update the patches this weekend. Alex
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On 16.04.2012, at 21:46, Blue Swirl wrote: On Mon, Apr 16, 2012 at 19:28, Peter Maydell peter.mayd...@linaro.org wrote: On 16 April 2012 20:12, Blue Swirl blauwir...@gmail.com wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. I use stgit a lot and I haven't run into this issue yet... Couple of approaches that spring to mind: 1. use stg rebase ppc-next to put your patch stack on top of ppc-next (This is how I did the recent cp15-rework series which sits on top of the drop-cpu_reset_model_id patchset, for instance.) 2. create a new branch starting from ppc-next and stg pick the relevant patches into it. (I use that for sending subsets of omap related patches from qemu-linaro.) Thanks, cool. I'll try that. I'm considering dropping stgit (it has emptied too many patches) and use plain git, this way I could start using branches. So how are things going there? Apparently all the patches from ppc-next should be in mainline, Andreas is happy with the state of QOM on PPC as it is by now too, so it's a perfect point in time to do this change! Alex
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On 31.03.2012, at 18:25, Blue Swirl wrote: Split PPC op helpers, convert to AREG0 free operation. Survives simple tests. FPU and SPE as well as integer and vector ops could be split further, each to their own file. This can be done also later. It could be possible to move some code from hw/ppc.c to various helpers but that can also be done later. Actually exceptions (#12 to #14) should have been converted before others because they can be called from code without AREG0 set up. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Very nice patch set! If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. Alex
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: On 31.03.2012, at 18:25, Blue Swirl wrote: Split PPC op helpers, convert to AREG0 free operation. Survives simple tests. FPU and SPE as well as integer and vector ops could be split further, each to their own file. This can be done also later. It could be possible to move some code from hw/ppc.c to various helpers but that can also be done later. Actually exceptions (#12 to #14) should have been converted before others because they can be called from code without AREG0 set up. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Very nice patch set! If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. Perhaps you could send a PULL for ppc-next, I'll push that and then rebase the patches? Alex
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On 16.04.2012, at 21:12, Blue Swirl wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: On 31.03.2012, at 18:25, Blue Swirl wrote: Split PPC op helpers, convert to AREG0 free operation. Survives simple tests. FPU and SPE as well as integer and vector ops could be split further, each to their own file. This can be done also later. It could be possible to move some code from hw/ppc.c to various helpers but that can also be done later. Actually exceptions (#12 to #14) should have been converted before others because they can be called from code without AREG0 set up. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Very nice patch set! If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. Perhaps you could send a PULL for ppc-next, I'll push that and then rebase the patches? Sounds great, but I need to catch up with Andreas and check what needs to be done to coordinate this properly with the QOM conversion. I'll try to get that done tomorrow, so by tomorrow night I should have a pull request out with whatever is left outstanding :). And then based on that, I'd be more than happy to have you apply them to qemu.git. Alex
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On 16 April 2012 20:12, Blue Swirl blauwir...@gmail.com wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. I use stgit a lot and I haven't run into this issue yet... Couple of approaches that spring to mind: 1. use stg rebase ppc-next to put your patch stack on top of ppc-next (This is how I did the recent cp15-rework series which sits on top of the drop-cpu_reset_model_id patchset, for instance.) 2. create a new branch starting from ppc-next and stg pick the relevant patches into it. (I use that for sending subsets of omap related patches from qemu-linaro.) -- PMM
Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
On Mon, Apr 16, 2012 at 19:28, Peter Maydell peter.mayd...@linaro.org wrote: On 16 April 2012 20:12, Blue Swirl blauwir...@gmail.com wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: If you can update it on top of ppc-next and add patch descriptions in every patch (more than just the subject line), I'll happily apply it and if possible also pull it in before the hard freeze. OK. Thanks for the review. But I'd prefer to apply them directly to qemu.git, because I'm using StGit for the patch stack and it doesn't work with different branches. I use stgit a lot and I haven't run into this issue yet... Couple of approaches that spring to mind: 1. use stg rebase ppc-next to put your patch stack on top of ppc-next (This is how I did the recent cp15-rework series which sits on top of the drop-cpu_reset_model_id patchset, for instance.) 2. create a new branch starting from ppc-next and stg pick the relevant patches into it. (I use that for sending subsets of omap related patches from qemu-linaro.) Thanks, cool. I'll try that. I'm considering dropping stgit (it has emptied too many patches) and use plain git, this way I could start using branches. -- PMM
[Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion
Split PPC op helpers, convert to AREG0 free operation. Survives simple tests.
FPU and SPE as well as integer and vector ops could be split further,
each to their own file. This can be done also later.
It could be possible to move some code from hw/ppc.c to various
helpers but that can also be done later.
Actually exceptions (#12 to #14) should have been converted before
others because they can be called from code without AREG0 set up.
URL git://repo.or.cz/qemu/blueswirl.git
http://repo.or.cz/r/qemu/blueswirl.git
Blue Swirl (20):
ppc: fix coding style in op_helper.c
ppc: split FPU and SPE ops
ppc: avoid AREG0 for FPU and SPE helpers
ppc: split integer and vector ops
ppc: avoid AREG0 for integer and vector helpers
ppc: fix coding style in helper.c
ppc: split MMU etc. helpers from op_helper.c
ppc: avoid AREG0 for MMU etc. helpers
ppc: avoid a warning with the next patch
ppc: move MMU helpers from helper.c to mmu_helper.c
ppc: cleanup MMU merge
ppc: split exception helpers
ppc: avoid AREG0 for exception helpers
ppc: move exception helpers from helper.c to excp_helper.c
ppc: split off timebase helpers
ppc: avoid AREG0 for timebase helpers
ppc: split off misc helpers
ppc: avoid AREG0 for misc helpers
ppc: move misc helpers from helper.c to misc_helper.c
ppc: move load and store helpers, switch to AREG0 free mode
Makefile.target |9 +-
configure |2 +-
target-ppc/cpu.h | 24 -
target-ppc/excp_helper.c | 965 +++
target-ppc/fpu_helper.c | 1738 +
target-ppc/helper.c | 3128 +--
target-ppc/helper.h | 572 ++--
target-ppc/int_helper.c | 1565 +++
target-ppc/mem_helper.c | 303 +++
target-ppc/misc_helper.c | 124 +
target-ppc/{helper.c = mmu_helper.c} | 1760 +++---
target-ppc/op_helper.c| 4570 -
target-ppc/timebase_helper.c | 159 ++
target-ppc/translate.c| 453 ++--
target-ppc/translate_init.c | 74 +-
15 files changed, 6364 insertions(+), 9082 deletions(-)
create mode 100644 target-ppc/excp_helper.c
create mode 100644 target-ppc/fpu_helper.c
create mode 100644 target-ppc/int_helper.c
create mode 100644 target-ppc/mem_helper.c
create mode 100644 target-ppc/misc_helper.c
copy target-ppc/{helper.c = mmu_helper.c} (67%)
delete mode 100644 target-ppc/op_helper.c
create mode 100644 target-ppc/timebase_helper.c
--
1.7.9
