Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
Paul Brook p...@codesourcery.com writes: *can* use it for something entirely else, if=sd notwithstanding: (qemu) device_add lsi (qemu) device_add scsi-cd,drive=sd0 If/when we get a PCI SD card controller model, would all the PCI using machines need to be added to take the 'no default sd card' setting out again, or does it get overridden anyway if you say and I'd like an sd controller? For SD cards we shouldn't need this to start with. Why are we creating SD cards when there's no host controller to connect them to? Surely we shold be able to figure that out automatically. Especially important for board variants with multiple SD interfaces. Is this all a hangover from before we have proper -drive options? As far as I can tell, we used to create default drives unconditionally. Commit aa40fc9c (v0.13) added -nodefaults to suppress them all, and commit ac33f8fa (v0.13) added means for boards to suppress them selectively. Commit e3260506 (v1.1) suppressed SD card for xilinx-zynq-a9, and commit ad0bbc56 (v1.1) suppress all three for s390-virtio. My patch series fixes up all boards to suppress all unused drives. Better late than never. We can certainly try to detect board uses default drive X automatically, so that boards don't have to declare their need explicitly. But considering how close we are to the freeze, I prefer my simple and safe fix for now. We can always improve on it later.
[Qemu-devel] [PATCH 00/23] Suppress unused default drives
We create a number of default drives for machines to use: floppy, CD-ROM, SD card. Machines can suppress the ones they don't use, but few do. Fix that. I split this into parts that share target and maintainer for review. Blue, would you be willing to commit the whole series, provided there are no objections? Cc: Alexander Graf ag...@suse.de Cc: Andreas Färber andreas.faer...@web.de Cc: Andrzej Zaborowski balr...@gmail.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Blue Swirl blauwir...@gmail.com Cc: Dmitry Solodkiy d.solod...@samsung.com Cc: Edgar E. Iglesias edgar.igles...@gmail.com Cc: Evgeny Voevodin e.voevo...@samsung.com Cc: Hervé Poussineau hpous...@reactos.org Cc: Igor Mitsyanko i.mitsya...@samsung.com Cc: Jan Kiszka jan.kis...@web.de Cc: Magnus Damm magnus.d...@gmail.com Cc: Maksim Kozlov m.koz...@samsung.com Cc: Mark Langsdorf mark.langsd...@calxeda.com Cc: Max Filippov jcmvb...@gmail.com Cc: Michael Walle mich...@walle.cc Cc: Paul Brook p...@codesourcery.com Cc: Paul Brook p...@codesourcery.com Cc: Peter Chubb peter.ch...@nicta.com.au Cc: Peter Crosthwaite peter.crosthwa...@petalogix.com Cc: Peter Maydell peter.mayd...@linaro.org Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: qemu-...@nongnu.org Markus Armbruster (23): alpha_dp264: Suppress unused default drives nseries palm spitz: Suppress unused default drives highbank: Suppress unused default drives integratorcp, realview, stellaris, versatilepb: Suppress unused default drives omap_sx1: Suppress unused default drives kzm: Suppress unused default drives musicpal: Suppress unused default drives exynos4: Suppress unused default drives xilinx-zynq: Suppress unused default drives collie gumstix mainstone tosa vexpress z2: Suppress unused default drives axis-dev88: Suppress unused default drives pc xen: Suppress unused default drives lm32: Suppress unused default drives m68k: Suppress unused default drives microblaze: Suppress unused default drives mips_jazz: Suppress unused default drives mips_malta mips_r4k: Suppress unused default drives mips_fulong2e, mips_mipssim: Suppress unused default drives or32-sim: Suppress unused default drives ppc: Suppress unused default drives sh4: Suppress unused default drives sparc: Suppress unused default drives xtensa: Suppress unused default drives hw/alpha_dp264.c | 2 ++ hw/an5206.c | 3 +++ hw/axis_dev88.c | 3 +++ hw/collie.c | 3 +++ hw/dummy_m68k.c | 3 +++ hw/exynos4_boards.c | 6 ++ hw/gumstix.c | 4 hw/highbank.c | 3 +++ hw/integratorcp.c | 2 ++ hw/kzm.c | 3 +++ hw/leon3.c| 3 +++ hw/lm32_boards.c | 6 ++ hw/mainstone.c| 2 ++ hw/mcf5208.c | 3 +++ hw/milkymist.c| 2 ++ hw/mips_fulong2e.c| 2 ++ hw/mips_jazz.c| 2 ++ hw/mips_malta.c | 1 + hw/mips_mipssim.c | 3 +++ hw/mips_r4k.c | 2 ++ hw/musicpal.c | 3 +++ hw/nseries.c | 4 hw/omap_sx1.c | 4 hw/openrisc_sim.c | 3 +++ hw/palm.c | 2 ++ hw/pc_piix.c | 11 +++ hw/petalogix_ml605_mmu.c | 3 +++ hw/petalogix_s3adsp1800_mmu.c | 3 +++ hw/ppc405_boards.c| 6 ++ hw/ppc440_bamboo.c| 3 +++ hw/ppc_newworld.c | 2 ++ hw/ppc_oldworld.c | 2 ++ hw/ppc_prep.c | 1 + hw/r2d.c | 3 +++ hw/realview.c | 6 ++ hw/shix.c | 3 +++ hw/spitz.c| 8 hw/stellaris.c| 5 + hw/sun4m.c| 15 +++ hw/sun4u.c| 3 +++ hw/tosa.c | 2 ++ hw/versatilepb.c | 2 ++ hw/vexpress.c | 4 hw/virtex_ml507.c | 3 +++ hw/xen_machine_pv.c | 1 + hw/xilinx_zynq.c | 2 ++ hw/xtensa_lx60.c | 6 ++ hw/xtensa_sim.c | 3 +++ hw/z2.c | 2 ++ 49 files changed, 173 insertions(+) -- 1.7.11.2
Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
On 9 August 2012 14:31, Markus Armbruster arm...@redhat.com wrote: We create a number of default drives for machines to use: floppy, CD-ROM, SD card. Machines can suppress the ones they don't use, but few do. Fix that. For clarity: what are the negative effects that result from machines not saying no_floppy c ? -- PMM
Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
Peter Maydell peter.mayd...@linaro.org writes: On 9 August 2012 15:08, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: For clarity: what are the negative effects that result from machines not saying no_floppy c ? info block shows the unused default drives. For instance, $ qemu-system-x86_64 -vnc :0 -monitor stdio QEMU 1.1.50 monitor - type 'help' for more information (qemu) info block ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted] floppy0: removable=1 locked=0 tray-open=0 [not inserted] sd0: removable=1 locked=0 tray-open=0 [not inserted] pflash0: removable=0 file=/work/armbru/qemu/bld-x86/pc-bios/bios.bin ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 Drive sd0 is unused here. Might confuse the uninitiated. Moreover, you *can* use it for something entirely else, if=sd notwithstanding: (qemu) device_add lsi (qemu) device_add scsi-cd,drive=sd0 If/when we get a PCI SD card controller model, would all the PCI using machines need to be added to take the 'no default sd card' setting out again, or does it get overridden anyway if you say and I'd like an sd controller? .no_sdcard = 0 makes sense only when the board uses the default IF_SD drive. Existence of an PCI SD card device model for the user to -device is not relevant for the board's QEMUmachine member no_sdcard. QEMUmachine describes the board, not devices that could be added to it. Only when we add an SD card to a board should its QEMUmachine no_sdcard go back to 0.
Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
*can* use it for something entirely else, if=sd notwithstanding: (qemu) device_add lsi (qemu) device_add scsi-cd,drive=sd0 If/when we get a PCI SD card controller model, would all the PCI using machines need to be added to take the 'no default sd card' setting out again, or does it get overridden anyway if you say and I'd like an sd controller? For SD cards we shouldn't need this to start with. Why are we creating SD cards when there's no host controller to connect them to? Surely we shold be able to figure that out automatically. Especially important for board variants with multiple SD interfaces. Is this all a hangover from before we have proper -drive options? Paul
Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
Peter Maydell peter.mayd...@linaro.org writes: On 9 August 2012 14:31, Markus Armbruster arm...@redhat.com wrote: We create a number of default drives for machines to use: floppy, CD-ROM, SD card. Machines can suppress the ones they don't use, but few do. Fix that. For clarity: what are the negative effects that result from machines not saying no_floppy c ? info block shows the unused default drives. For instance, $ qemu-system-x86_64 -vnc :0 -monitor stdio QEMU 1.1.50 monitor - type 'help' for more information (qemu) info block ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted] floppy0: removable=1 locked=0 tray-open=0 [not inserted] sd0: removable=1 locked=0 tray-open=0 [not inserted] pflash0: removable=0 file=/work/armbru/qemu/bld-x86/pc-bios/bios.bin ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 Drive sd0 is unused here. Might confuse the uninitiated. Moreover, you *can* use it for something entirely else, if=sd notwithstanding: (qemu) device_add lsi (qemu) device_add scsi-cd,drive=sd0
Re: [Qemu-devel] [PATCH 00/23] Suppress unused default drives
On 9 August 2012 15:08, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: For clarity: what are the negative effects that result from machines not saying no_floppy c ? info block shows the unused default drives. For instance, $ qemu-system-x86_64 -vnc :0 -monitor stdio QEMU 1.1.50 monitor - type 'help' for more information (qemu) info block ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted] floppy0: removable=1 locked=0 tray-open=0 [not inserted] sd0: removable=1 locked=0 tray-open=0 [not inserted] pflash0: removable=0 file=/work/armbru/qemu/bld-x86/pc-bios/bios.bin ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 Drive sd0 is unused here. Might confuse the uninitiated. Moreover, you *can* use it for something entirely else, if=sd notwithstanding: (qemu) device_add lsi (qemu) device_add scsi-cd,drive=sd0 If/when we get a PCI SD card controller model, would all the PCI using machines need to be added to take the 'no default sd card' setting out again, or does it get overridden anyway if you say and I'd like an sd controller? -- PMM
