Re: [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate

[Christoph Hellwig]

On Mon, Jan 18, 2010 at 01:11:28PM +0100, Kevin Wolf wrote:
 Don't assume success but pass the bdrv_pwrite return value on.

Looks good,


Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate

[Kevin Wolf]

Don't assume success but pass the bdrv_pwrite return value on.

Signed-off-by: Kevin Wolf kw...@redhat.com
---
 block/qcow2.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 6622eba..e06f4dd 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1163,12 +1163,13 @@ static int qcow_save_vmstate(BlockDriverState *bs, 
const uint8_t *buf,
 {
 BDRVQcowState *s = bs-opaque;
 int growable = bs-growable;
+int ret;
 
 bs-growable = 1;
-bdrv_pwrite(bs, qcow_vm_state_offset(s) + pos, buf, size);
+ret = bdrv_pwrite(bs, qcow_vm_state_offset(s) + pos, buf, size);
 bs-growable = growable;
 
-return size;
+return ret;
 }
 
 static int qcow_load_vmstate(BlockDriverState *bs, uint8_t *buf,
-- 
1.6.2.5