Re: [Qemu-devel] [PATCH 02/15] hw/omap_gpio.c: Don't complain about some writes to r/o registers
On 30 July 2011 05:53, andrzej zaborowski balr...@gmail.com wrote:
I went ahead and pushed the series
Thanks.
with the exception of this patch
and 14/15 because I think these are the types of patches that should
remain in downstream as a reminder, is there an argument for not
fixing these things in Linux?
I think the only arguments are it's too hard and I'd like to
run legacy images without having qemu constantly complaining and
making '-serial stdio' unusable :-) [have you seen how much chatter
you get out of n810 running a meego image?] I think I've said before
that really we ought to have this kind of message more consistently
and conveniently enablable/disablable.
I'll leave this sort of change out of future patches; when I get
down to the point where they're the only thing left in my patch
stack (a) I'll be very happy and (b) I might look at a nicer way
to handle them.
In patch 04 I renamed omap2_gpio_module_set to omap2_gpio_set because
the parameter is no longer the module pointer. By the way I think we
should also pass the target agent pointer on creation the same way
clocks are passed and use omap_l4_attach.
The clock passing thing is (as per comments) a bit nasty; at
the moment sysbus is the closest we have to a nice way of exposing
I have some MMIO regions so I'm a bit reluctant to hide it behind
another magic pointer property. I'll have a think about this, though.
In patch 07 I bumped the vmstate version because the structure seems
to have changed.
Oops, yes. I had a note at some point to look more carefully at
the vmstate change but I must have forgotten about it :-(
I agree we can just bump the version.
In patch 12 I removed the
else {
s-bdrv_cur = s-bdrv;
} part because there seemed to be no reason to add it, please check
that I haven't broken something.
That looks like it should be OK, we'll always call onenand_reset()
which will set bdrv_cur to bdrv.
-- PMM
[Qemu-devel] [PATCH 02/15] hw/omap_gpio.c: Don't complain about some writes to r/o registers
Don't complain about some writes to r/o OMAP2 GPIO registers, because the kernel will do them anyway. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/omap_gpio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c index 478f7d9..b53b13b 100644 --- a/hw/omap_gpio.c +++ b/hw/omap_gpio.c @@ -385,7 +385,7 @@ static void omap2_gpio_module_write(void *opaque, target_phys_addr_t addr, case 0x00: /* GPIO_REVISION */ case 0x14: /* GPIO_SYSSTATUS */ case 0x38: /* GPIO_DATAIN */ -OMAP_RO_REG(addr); +/* read-only, ignore quietly */ break; case 0x10: /* GPIO_SYSCONFIG */ @@ -531,7 +531,7 @@ static void omap2_gpio_module_writep(void *opaque, target_phys_addr_t addr, case 0x00: /* GPIO_REVISION */ case 0x14: /* GPIO_SYSSTATUS */ case 0x38: /* GPIO_DATAIN */ -OMAP_RO_REG(addr); +/* read-only, ignore quietly */ break; case 0x10: /* GPIO_SYSCONFIG */ -- 1.7.1
