Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-11-14 Thread Andreas Färber 
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
 module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
 doesn't include it.
 
 The header is probably being included by accident because some other
 headers are including qemu-common.h, but those headers should eventually
 stop including qemu-common.h.
 
 Signed-off-by: Eduardo Habkost ehabk...@redhat.com

Acked-by: Andreas Färber afaer...@suse.de

I'm surprised about this machine_init() use case outside a machine though...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-11-09 Thread Eduardo Habkost 
module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
doesn't include it.

The header is probably being included by accident because some other
headers are including qemu-common.h, but those headers should eventually
stop including qemu-common.h.

Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
 fsdev/qemu-fsdev-dummy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c
index 4e700dd..300f275 100644
--- a/fsdev/qemu-fsdev-dummy.c
+++ b/fsdev/qemu-fsdev-dummy.c
@@ -14,6 +14,7 @@
 #include string.h
 #include qemu-fsdev.h
 #include qemu-config.h
+#include module.h
 
 int qemu_fsdev_add(QemuOpts *opts)
 {
-- 
1.7.11.4

[Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-11-09 Thread Eduardo Habkost 
module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
doesn't include it.

The header is probably being included by accident because some other
headers are including qemu-common.h, but those headers should eventually
stop including qemu-common.h.

Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
 fsdev/qemu-fsdev-dummy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c
index 4e700dd..300f275 100644
--- a/fsdev/qemu-fsdev-dummy.c
+++ b/fsdev/qemu-fsdev-dummy.c
@@ -14,6 +14,7 @@
 #include string.h
 #include qemu-fsdev.h
 #include qemu-config.h
+#include module.h
 
 int qemu_fsdev_add(QemuOpts *opts)
 {
-- 
1.7.11.7

[Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h

2012-10-23 Thread Eduardo Habkost 
module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
doesn't include it.

The header is probably being included by accident because some other
headers are including qemu-common.h, but those headers should eventually
stop including qemu-common.h.

Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
 fsdev/qemu-fsdev-dummy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c
index 4e700dd..300f275 100644
--- a/fsdev/qemu-fsdev-dummy.c
+++ b/fsdev/qemu-fsdev-dummy.c
@@ -14,6 +14,7 @@
 #include string.h
 #include qemu-fsdev.h
 #include qemu-config.h
+#include module.h
 
 int qemu_fsdev_add(QemuOpts *opts)
 {
-- 
1.7.11.7