Re: [Qemu-devel] [PATCH 1/2] Add VMSTATE_STRUCT_VARRAY_KNOWN

2016-01-08 Thread Amit Shah
On (Wed) 06 Jan 2016 [12:23:38], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" 
> 
> At the moment we have VMSTATE_STRUCT_ARRAY that requires
> the field is declared as an array of fixed size.
> We also have VMSTATE_STRUCT_VARRAY_UINT* that allows
> a field declared as a pointer, but requires that the length
> is a field member in the structure being loaded/saved.
> 
> VMSTATE_STRUCT_VARRAY_KNOWN is for arrays defined as pointers
> yet we somehow know the length of.
> 
> Signed-off-by: Dr. David Alan Gilbert 

Reviewed-by: Amit Shah 

Amit



[Qemu-devel] [PATCH 1/2] Add VMSTATE_STRUCT_VARRAY_KNOWN

2016-01-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" 

At the moment we have VMSTATE_STRUCT_ARRAY that requires
the field is declared as an array of fixed size.
We also have VMSTATE_STRUCT_VARRAY_UINT* that allows
a field declared as a pointer, but requires that the length
is a field member in the structure being loaded/saved.

VMSTATE_STRUCT_VARRAY_KNOWN is for arrays defined as pointers
yet we somehow know the length of.

Signed-off-by: Dr. David Alan Gilbert 
---
 include/migration/vmstate.h | 13 +
 1 file changed, 13 insertions(+)

diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 7267e38..97d44d3 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -374,6 +374,19 @@ extern const VMStateInfo vmstate_info_bitmap;
 .offset   = vmstate_offset_array(_state, _field, _type, _num),\
 }
 
+/* a variable length array (i.e. _type *_field) but we know the
+ * length
+ */
+#define VMSTATE_STRUCT_VARRAY_KNOWN(_field, _state, _num, _version, _vmsd, 
_type) { \
+.name   = (stringify(_field)),   \
+.num  = (_num),  \
+.version_id = (_version),\
+.vmsd   = &(_vmsd),  \
+.size   = sizeof(_type), \
+.flags  = VMS_STRUCT|VMS_ARRAY,  \
+.offset = offsetof(_state, _field),  \
+}
+
 #define VMSTATE_STRUCT_VARRAY_UINT8(_field, _state, _field_num, _version, 
_vmsd, _type) { \
 .name   = (stringify(_field)),   \
 .num_offset = vmstate_offset_value(_state, _field_num, uint8_t), \
-- 
2.5.0