Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev 
Applied (finally!) to -trivial, without already fixed -net and -scsi bits.
Thanks!

/mjt

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-09-11 Thread Andreas Färber 
Michael,

Am 11.09.2015 um 10:00 schrieb Michael Tokarev:
> Applied (finally!) to -trivial, without already fixed -net and -scsi bits.
> Thanks!

Can you please tweak the subjects? I found "blank Property" a very
troubling thing to read. In fact it's an empty Property[] array.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Shannon Zhao 


On 2015/5/12 15:52, Peter Maydell wrote:
 On 12 May 2015 at 03:25,  shannon.z...@linaro.org wrote:
  From: Shannon Zhao shannon.z...@linaro.org
 
  Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com
  Signed-off-by: Shannon Zhao shannon.z...@linaro.org
  ---
   hw/s390x/s390-virtio-bus.c | 15 ---
   1 file changed, 15 deletions(-)
 
  diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
  index 1a72b56..273bd9c 100644
  --- a/hw/s390x/s390-virtio-bus.c
  +++ b/hw/s390x/s390-virtio-bus.c
  @@ -536,17 +536,12 @@ static unsigned virtio_s390_get_features(DeviceState 
  *d)
 
 Net and scsi are already fixed in master (I had to do that
 as part of the conflict resolution between your virtio
 patches and Cornelia's).

Ok, so need to respin?

-- 
Shannon

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Cornelia Huck 
On Tue, 12 May 2015 10:25:16 +0800
shannon.z...@linaro.org wrote:

 From: Shannon Zhao shannon.z...@linaro.org
 
 Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com
 Signed-off-by: Shannon Zhao shannon.z...@linaro.org
 ---
  hw/s390x/s390-virtio-bus.c | 15 ---
  1 file changed, 15 deletions(-)
 

Acked-by: Cornelia Huck cornelia.h...@de.ibm.com

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Peter Maydell 
On 12 May 2015 at 03:25,  shannon.z...@linaro.org wrote:
 From: Shannon Zhao shannon.z...@linaro.org

 Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com
 Signed-off-by: Shannon Zhao shannon.z...@linaro.org
 ---
  hw/s390x/s390-virtio-bus.c | 15 ---
  1 file changed, 15 deletions(-)

 diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
 index 1a72b56..273bd9c 100644
 --- a/hw/s390x/s390-virtio-bus.c
 +++ b/hw/s390x/s390-virtio-bus.c
 @@ -536,17 +536,12 @@ static unsigned virtio_s390_get_features(DeviceState *d)


Net and scsi are already fixed in master (I had to do that
as part of the conflict resolution between your virtio
patches and Cornelia's).

-- PMM

[Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-11 Thread shannon . zhao 
From: Shannon Zhao shannon.z...@linaro.org

Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com
Signed-off-by: Shannon Zhao shannon.z...@linaro.org
---
 hw/s390x/s390-virtio-bus.c | 15 ---
 1 file changed, 15 deletions(-)

diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c
index 1a72b56..273bd9c 100644
--- a/hw/s390x/s390-virtio-bus.c
+++ b/hw/s390x/s390-virtio-bus.c
@@ -536,17 +536,12 @@ static unsigned virtio_s390_get_features(DeviceState *d)
 
 / S390 Virtio Bus Device Descriptions ***/
 
-static Property s390_virtio_net_properties[] = {
-DEFINE_PROP_END_OF_LIST(),
-};
-
 static void s390_virtio_net_class_init(ObjectClass *klass, void *data)
 {
 DeviceClass *dc = DEVICE_CLASS(klass);
 VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
 
 k-realize = s390_virtio_net_realize;
-dc-props = s390_virtio_net_properties;
 set_bit(DEVICE_CATEGORY_NETWORK, dc-categories);
 }
 
@@ -575,17 +570,12 @@ static const TypeInfo s390_virtio_blk = {
 .class_init= s390_virtio_blk_class_init,
 };
 
-static Property s390_virtio_serial_properties[] = {
-DEFINE_PROP_END_OF_LIST(),
-};
-
 static void s390_virtio_serial_class_init(ObjectClass *klass, void *data)
 {
 DeviceClass *dc = DEVICE_CLASS(klass);
 VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
 
 k-realize = s390_virtio_serial_realize;
-dc-props = s390_virtio_serial_properties;
 set_bit(DEVICE_CATEGORY_INPUT, dc-categories);
 }
 
@@ -655,17 +645,12 @@ static const TypeInfo virtio_s390_device_info = {
 .abstract = true,
 };
 
-static Property s390_virtio_scsi_properties[] = {
-DEFINE_PROP_END_OF_LIST(),
-};
-
 static void s390_virtio_scsi_class_init(ObjectClass *klass, void *data)
 {
 DeviceClass *dc = DEVICE_CLASS(klass);
 VirtIOS390DeviceClass *k = VIRTIO_S390_DEVICE_CLASS(klass);
 
 k-realize = s390_virtio_scsi_realize;
-dc-props = s390_virtio_scsi_properties;
 set_bit(DEVICE_CATEGORY_STORAGE, dc-categories);
 }
 
-- 
2.1.0