Re: [Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests

2013-10-31 Thread Eric Blake 
On 10/31/2013 09:57 AM, Jeff Cody wrote:
 The usage of $TEST_IMG was not properly quoted everywhere in
 common.pattern.
 
 Signed-off-by: Jeff Cody jc...@redhat.com
 ---
  tests/qemu-iotests/common.pattern | 12 ++--
  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake ebl...@redhat.com

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature

[Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests

2013-10-31 Thread Jeff Cody 
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.

Signed-off-by: Jeff Cody jc...@redhat.com
---
 tests/qemu-iotests/common.pattern | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/qemu-iotests/common.pattern 
b/tests/qemu-iotests/common.pattern
index 00e0f60..ddfbca1 100644
--- a/tests/qemu-iotests/common.pattern
+++ b/tests/qemu-iotests/common.pattern
@@ -28,7 +28,7 @@ function do_is_allocated() {
 }
 
 function is_allocated() {
-do_is_allocated $@ | $QEMU_IO $TEST_IMG | _filter_qemu_io
+do_is_allocated $@ | $QEMU_IO $TEST_IMG | _filter_qemu_io
 }
 
 function do_io() {
@@ -46,18 +46,18 @@ function do_io() {
 }
 
 function io_pattern() {
-do_io $@ | $QEMU_IO $TEST_IMG | _filter_qemu_io
+do_io $@ | $QEMU_IO $TEST_IMG | _filter_qemu_io
 }
 
 function io() {
 local start=$2
 local pattern=$(( (start  9) % 256 ))
 
-do_io $@ $pattern | $QEMU_IO $TEST_IMG | _filter_qemu_io
+do_io $@ $pattern | $QEMU_IO $TEST_IMG | _filter_qemu_io
 }
 
 function io_zero() {
-do_io $@ 0 | $QEMU_IO $TEST_IMG | _filter_qemu_io
+do_io $@ 0 | $QEMU_IO $TEST_IMG | _filter_qemu_io
 }
 
 function io_test() {
@@ -117,8 +117,8 @@ function io_test2() {
 echo === Clusters to be compressed [3]
 io_pattern writev $((offset + 8 * $cluster_size)) $cluster_size $((9 * 
$cluster_size)) $num 165
 
-mv $TEST_IMG $TEST_IMG.orig
-$QEMU_IMG convert -f $IMGFMT -O $IMGFMT -c $TEST_IMG.orig $TEST_IMG
+mv $TEST_IMG $TEST_IMG.orig
+$QEMU_IMG convert -f $IMGFMT -O $IMGFMT -c $TEST_IMG.orig $TEST_IMG
 
 # Write the used clusters
 echo === Used clusters [1]
-- 
1.8.3.1