Re: [Qemu-devel] [PATCH 1/9] tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro

2018-12-10 Thread Philippe Mathieu-Daudé 
On 12/10/18 7:10 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov 

Reviewed-by: Philippe Mathieu-Daudé 

> ---
>  tests/acpi-utils.h | 8 
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
> index 4f4899d..c8844a2 100644
> --- a/tests/acpi-utils.h
> +++ b/tests/acpi-utils.h
> @@ -70,14 +70,6 @@ typedef struct {
>  g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
>  } while (0)
>  
> -#define ACPI_READ_GENERIC_ADDRESS(field, addr)   \
> -do { \
> -ACPI_READ_FIELD((field).space_id, addr); \
> -ACPI_READ_FIELD((field).bit_width, addr);\
> -ACPI_READ_FIELD((field).bit_offset, addr);   \
> -ACPI_READ_FIELD((field).access_width, addr); \
> -ACPI_READ_FIELD((field).address, addr);  \
> -} while (0)
>  
>  
>  uint8_t acpi_calc_checksum(const uint8_t *data, int len);
>

[Qemu-devel] [PATCH 1/9] tests: acpi: remove not used ACPI_READ_GENERIC_ADDRESS macro

2018-12-10 Thread Igor Mammedov 
Signed-off-by: Igor Mammedov 
---
 tests/acpi-utils.h | 8 
 1 file changed, 8 deletions(-)

diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
index 4f4899d..c8844a2 100644
--- a/tests/acpi-utils.h
+++ b/tests/acpi-utils.h
@@ -70,14 +70,6 @@ typedef struct {
 g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
 } while (0)
 
-#define ACPI_READ_GENERIC_ADDRESS(field, addr)   \
-do { \
-ACPI_READ_FIELD((field).space_id, addr); \
-ACPI_READ_FIELD((field).bit_width, addr);\
-ACPI_READ_FIELD((field).bit_offset, addr);   \
-ACPI_READ_FIELD((field).access_width, addr); \
-ACPI_READ_FIELD((field).address, addr);  \
-} while (0)
 
 
 uint8_t acpi_calc_checksum(const uint8_t *data, int len);
-- 
2.7.4