Re: [Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own

2011-07-26 Thread Markus Armbruster 
Christoph Hellwig  writes:

> On Wed, Jul 20, 2011 at 06:23:51PM +0200, Markus Armbruster wrote:
>> 
>> Signed-off-by: Markus Armbruster 
>
> Looks good, although I would have folded this patch into the previous
> one.

I'll consider squashing when I respin.

Re: [Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own

2011-07-26 Thread Christoph Hellwig 
On Wed, Jul 20, 2011 at 06:23:51PM +0200, Markus Armbruster wrote:
> 
> Signed-off-by: Markus Armbruster 

Looks good, although I would have folded this patch into the previous
one.

Reviewed-by: Christoph Hellwig

[Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own

2011-07-20 Thread Markus Armbruster 

Signed-off-by: Markus Armbruster 
---
 hw/ide/atapi.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index fee567b..96f7c31 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -510,7 +510,7 @@ static unsigned int event_status_media(IDEState *s,
 uint8_t event_code, media_status;
 
 media_status = 0;
-if (s->bs->tray_open) {
+if (s->tray_open) {
 media_status = MS_TRAY_OPEN;
 } else if (bdrv_is_inserted(s->bs)) {
 media_status = MS_MEDIA_PRESENT;
-- 
1.7.2.3