[Qemu-devel] [PATCH 2/2] PPC: KVM: fix set one register

2014-01-05 Thread Alexey Kardashevskiy
Due to missing @one_reg_id assignment in _spr_register(),
the kvm_get_one_reg/kvm_set_one_reg API has never really been working.

This enabled the API and removes use of the API for LPCR as
kvm_arch_get_registers/kvm_arch_put_registers run a loop for all 1024 SPR
and LPCR is one of them.

Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
 target-ppc/translate_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 144de3d..149a932 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -628,6 +628,9 @@ static inline void _spr_register(CPUPPCState *env, int num,
 spr-oea_read = oea_read;
 spr-oea_write = oea_write;
 #endif
+#if defined(CONFIG_KVM)
+spr-one_reg_id = one_reg_id,
+#endif
 env-spr[num] = initial_value;
 }
 
-- 
1.8.4.rc4




Re: [Qemu-devel] [PATCH 2/2] PPC: KVM: fix set one register

2014-01-05 Thread Alexey Kardashevskiy
On 01/06/2014 04:36 PM, Alexey Kardashevskiy wrote:
 Due to missing @one_reg_id assignment in _spr_register(),
 the kvm_get_one_reg/kvm_set_one_reg API has never really been working.
 
 This enabled the API and removes use of the API for LPCR as
 kvm_arch_get_registers/kvm_arch_put_registers run a loop for all 1024 SPR
 and LPCR is one of them.

Agrh.

The commit message must be:
===
Due to missing @one_reg_id assignment in _spr_register(),
the kvm_get_one_reg/kvm_set_one_reg API has never really been working.

This reenables the API by assigning the @one_reg_id field in the SPR
descriptor.
===

Repost?


 
 Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
 ---
  target-ppc/translate_init.c | 3 +++
  1 file changed, 3 insertions(+)
 
 diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
 index 144de3d..149a932 100644
 --- a/target-ppc/translate_init.c
 +++ b/target-ppc/translate_init.c
 @@ -628,6 +628,9 @@ static inline void _spr_register(CPUPPCState *env, int 
 num,
  spr-oea_read = oea_read;
  spr-oea_write = oea_write;
  #endif
 +#if defined(CONFIG_KVM)
 +spr-one_reg_id = one_reg_id,
 +#endif
  env-spr[num] = initial_value;
  }
  
 


-- 
Alexey