Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64

2018-08-01 Thread Laurent Desnogues 
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson
 wrote:
> Used the wrong temporary in the computation of subtractive overflow.
>
> Reported-by: Laurent Desnogues 
> Signed-off-by: Richard Henderson 

Reviewed-by: Laurent Desnogues 
Tested-by: Laurent Desnogues 


Laurent

> ---
>  target/arm/translate-sve.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
> index 374051cd20..9dd4c38bab 100644
> --- a/target/arm/translate-sve.c
> +++ b/target/arm/translate-sve.c
> @@ -1625,7 +1625,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 
> val, bool u, bool d)
>  /* Detect signed overflow for subtraction.  */
>  tcg_gen_xor_i64(t0, reg, val);
>  tcg_gen_sub_i64(t1, reg, val);
> -tcg_gen_xor_i64(reg, reg, t0);
> +tcg_gen_xor_i64(reg, reg, t1);
>  tcg_gen_and_i64(t0, t0, reg);
>
>  /* Bound the result.  */
> --
> 2.17.1
>

[Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64

2018-08-01 Thread Richard Henderson 
Used the wrong temporary in the computation of subtractive overflow.

Reported-by: Laurent Desnogues 
Signed-off-by: Richard Henderson 
---
 target/arm/translate-sve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index 374051cd20..9dd4c38bab 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -1625,7 +1625,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 val, 
bool u, bool d)
 /* Detect signed overflow for subtraction.  */
 tcg_gen_xor_i64(t0, reg, val);
 tcg_gen_sub_i64(t1, reg, val);
-tcg_gen_xor_i64(reg, reg, t0);
+tcg_gen_xor_i64(reg, reg, t1);
 tcg_gen_and_i64(t0, t0, reg);
 
 /* Bound the result.  */
-- 
2.17.1