g_timeout_source_new() will initialize GSource's reference count to 1, and g_source_attach() will increase the count by 1, so it will not be enough to call just g_source_unref() which only reduce the value by 1. It will lead to memory leak.
We need to call g_source_destroy() before g_source_unref(). Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> --- net/colo-compare.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index d6a5e4c..97bf0e5 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -562,7 +562,9 @@ static void *colo_compare_thread(void *opaque) g_main_loop_run(s->compare_loop); + g_source_destroy(timeout_source); g_source_unref(timeout_source); + g_main_loop_unref(s->compare_loop); g_main_context_unref(s->worker_context); return NULL; -- 1.8.3.1