[Qemu-devel] [PATCH 4/4] block: Include qemu-log.o in block-obj-y

2015-05-08 Thread Dimitris Aragiorgis
Building the QEMU tools fails if we #define DEBUG_BLOCK inside
block/raw-posix.c. This happens because qemu-log.o is missing from
block-obj-y, which causes the link to fail. Fix this.

Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
---
 Makefile.objs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.objs b/Makefile.objs
index 28999d3..98f6e02 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -6,7 +6,7 @@ util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o 
qapi-event.o
 ###
 # block-obj-y is code used by both qemu system emulation and qemu-img
 
-block-obj-y = async.o thread-pool.o
+block-obj-y = async.o thread-pool.o qemu-log.o
 block-obj-y += nbd.o block.o blockjob.o
 block-obj-y += main-loop.o iohandler.o qemu-timer.o
 block-obj-$(CONFIG_POSIX) += aio-posix.o
-- 
1.7.10.4




Re: [Qemu-devel] [PATCH 4/4] block: Include qemu-log.o in block-obj-y

2015-05-08 Thread Paolo Bonzini


On 08/05/2015 13:38, Dimitris Aragiorgis wrote:
 Building the QEMU tools fails if we #define DEBUG_BLOCK inside
 block/raw-posix.c. This happens because qemu-log.o is missing from
 block-obj-y, which causes the link to fail. Fix this.
 
 Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com

Let's just remove DEBUG_BLOCK messages.  There are only two and they
only trigger for error cases.

Paolo

 ---
  Makefile.objs |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/Makefile.objs b/Makefile.objs
 index 28999d3..98f6e02 100644
 --- a/Makefile.objs
 +++ b/Makefile.objs
 @@ -6,7 +6,7 @@ util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o 
 qapi-event.o
  ###
  # block-obj-y is code used by both qemu system emulation and qemu-img
  
 -block-obj-y = async.o thread-pool.o
 +block-obj-y = async.o thread-pool.o qemu-log.o
  block-obj-y += nbd.o block.o blockjob.o
  block-obj-y += main-loop.o iohandler.o qemu-timer.o
  block-obj-$(CONFIG_POSIX) += aio-posix.o